Changeset 95012 in webkit

Timestamp:

Sep 12, 2011 9:15:59 PM (13 years ago)

Author:

levin@chromium.org

Message:

[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
​https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

• src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess

allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WorkerFileWriterCallbacksBridge.cpp (modified) (7 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-12  David Levin  <levin@chromium.org>
+
+        [chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
+        https://bugs.webkit.org/show_bug.cgi?id=67943
+
+        Reviewed by Adam Barth.
+
+        * src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
+        allowing the automatic ref counting to work. This was previous needed when
+        the ref counting wasn't working but that was fixed in r94986. Note that the
+        design was to have ref counting since the methods take PassRefPtr and the
+        class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
+        adding in AllowCrossThreadAccess.)
+        (WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
+        (WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
+        (WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
+        (WebKit::WorkerFileWriterCallbacksBridge::didWrite):
+        (WebKit::WorkerFileWriterCallbacksBridge::didFail):
+        (WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
+        (WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
+        (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
+        (WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
+
 2011-09-08  Nat Duca  <nduca@chromium.org>
 

trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp

@@ -63 +63 @@
     m_operationInProgress = true;
     dispatchTaskToMainThread(createCallbackTask(&writeOnMainThread, 
-                                                AllowCrossThreadAccess(this), position, data));
+                                                this, position, data));
 }
 
@@ -71 +71 @@
     m_operationInProgress = true;
     dispatchTaskToMainThread(createCallbackTask(&truncateOnMainThread, 
-                                                AllowCrossThreadAccess(this), length));
+                                                this, length));
 }
 
@@ -77 +77 @@
 {
     ASSERT(m_operationInProgress);
-    dispatchTaskToMainThread(createCallbackTask(&abortOnMainThread, AllowCrossThreadAccess(this)));
+    dispatchTaskToMainThread(createCallbackTask(&abortOnMainThread, this));
 }
 
@@ -116 +116 @@
 void WorkerFileWriterCallbacksBridge::didWrite(long long bytes, bool complete)
 {
-    dispatchTaskToWorkerThread(createCallbackTask(&didWriteOnWorkerThread, AllowCrossThreadAccess(this), bytes, complete));
+    dispatchTaskToWorkerThread(createCallbackTask(&didWriteOnWorkerThread, this, bytes, complete));
 }
 
 void WorkerFileWriterCallbacksBridge::didFail(WebFileError error)
 {
-    dispatchTaskToWorkerThread(createCallbackTask(&didFailOnWorkerThread, AllowCrossThreadAccess(this), error));
+    dispatchTaskToWorkerThread(createCallbackTask(&didFailOnWorkerThread, this, error));
 }
 
 void WorkerFileWriterCallbacksBridge::didTruncate()
 {
-    dispatchTaskToWorkerThread(createCallbackTask(&didTruncateOnWorkerThread, AllowCrossThreadAccess(this)));
+    dispatchTaskToWorkerThread(createCallbackTask(&didTruncateOnWorkerThread, this));
 }
 
@@ -148 +148 @@
 {
     dispatchTaskToMainThread(
-        createCallbackTask(&initOnMainThread, AllowCrossThreadAccess(this), path));
+        createCallbackTask(&initOnMainThread, this, path));
 }
 
@@ -201 +201 @@
     ASSERT(m_workerContext->isContextThread());
     WebWorkerBase::dispatchTaskToMainThread(
-        createCallbackTask(&runTaskOnMainThread, AllowCrossThreadAccess(this), task));
+        createCallbackTask(&runTaskOnMainThread, this, task));
 }
 
@@ -208 +208 @@
     ASSERT(isMainThread());
     m_proxy->postTaskForModeToWorkerContext(
-        createCallbackTask(&runTaskOnWorkerThread, AllowCrossThreadAccess(this), task), m_mode);
+        createCallbackTask(&runTaskOnWorkerThread, this, task), m_mode);
 }