Changeset 95042 in webkit
- Timestamp:
- Sep 13, 2011 1:51:29 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r95040 r95042 1 2011-09-13 Ryosuke Niwa <rniwa@webkit.org> 2 3 sheriffbot whois should also tell us email addresses 4 https://bugs.webkit.org/show_bug.cgi?id=67975 5 6 Reviewed by Eric Seidel and David Levin. 7 8 Taught sheriffbot how to tell us contributor's email addresses. 9 10 * Scripts/webkitpy/tool/bot/irc_command.py: 11 * Scripts/webkitpy/tool/bot/irc_command_unittest.py: 12 1 13 2011-09-13 Eric Seidel <eric@webkit.org> 2 14 -
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
r94993 r95042 192 192 if not contributor.irc_nickname: 193 193 return "%s: %s hasn't told me their nick. Boo hoo :-(" % (nick, contributor) 194 return "%s: %s is %s. Why do you ask?" % (nick, search_string, contributor.irc_nickname) 194 if contributor.emails and search_string.lower() not in map(lambda email: email.lower(), contributor.emails): 195 formattedEmails = ', '.join(contributor.emails) 196 return "%s: %s is %s (%s). Why do you ask?" % (nick, search_string, contributor.irc_nickname, formattedEmails) 197 else: 198 return "%s: %s is %s. Why do you ask?" % (nick, search_string, contributor.irc_nickname) 195 199 contributor_nicks = map(self._nick_or_full_record, contributors) 196 200 contributors_string = join_with_separators(contributor_nicks, only_two_separator=" or ", last_separator=', or ') -
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py
r94993 r95042 50 50 self.assertEquals("tom: tonyg@chromium.org is tonyg-cr. Why do you ask?", 51 51 whois.execute("tom", ["tonyg@chromium.org"], None, None)) 52 self.assertEquals("tom: TonyG@Chromium.org is tonyg-cr. Why do you ask?", 53 whois.execute("tom", ["TonyG@Chromium.org"], None, None)) 54 self.assertEquals("tom: rniwa is rniwa (rniwa@webkit.org). Why do you ask?", 55 whois.execute("tom", ["rniwa"], None, None)) 56 self.assertEquals("tom: lopez is xan (xan.lopez@gmail.com, xan@gnome.org, xan@webkit.org). Why do you ask?", 57 whois.execute("tom", ["lopez"], None, None)) 52 58 self.assertEquals('tom: "Vicki Murley" <vicki@apple.com> hasn\'t told me their nick. Boo hoo :-(', 53 59 whois.execute("tom", ["vicki@apple.com"], None, None))
Note: See TracChangeset
for help on using the changeset viewer.