Changeset 95063 in webkit


Ignore:
Timestamp:
Sep 13, 2011 6:05:27 PM (13 years ago)
Author:
haraken@google.com
Message:

Implement a HashChangeEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=67969

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/events/constructors/hash-change-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
  • dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r95059 r95063  
     12011-09-13  Kentaro Hara  <haraken@google.com>
     2
     3        Implement a HashChangeEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=67969
     5
     6        Reviewed by Nate Chapin.
     7
     8        Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-09-13  Jeremy Apthorp  <jeremya@google.com>
    213

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r95032 r95063  
    8383BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
    8484BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
    85 
    86 // This will soon be fixed after implementing a HashChangeEvent constructor for V8.
    87 BUGWK67924 : fast/events/constructors/hash-change-event-constructor.html = FAIL
    8885
    8986// According to the Chromium bug, we need to write some sort of workaround for

  • trunk/Source/WebCore/ChangeLog

    r95059 r95063  
     12011-09-13  Kentaro Hara  <haraken@google.com>
     2
     3        Implement a HashChangeEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=67969
     5
     6        Reviewed by Nate Chapin.
     7
     8        Test: fast/events/constructors/hash-change-event-constructor.html
     9
     10        * bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
     11        * dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.
     12
    1132011-09-13  Jeremy Apthorp  <jeremya@google.com>
    214

  • trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

    r94953 r95063  
    3535#include "Document.h"
    3636#include "DocumentFragment.h"
     37#include "HashChangeEvent.h"
    3738#include "Node.h"
    3839#include "ProgressEvent.h"
    … …  
    4546#include "V8Document.h"
    4647#include "V8Event.h"
     48#include "V8HashChangeEvent.h"
    4749#include "V8Node.h"
    4850#include "V8ProgressEvent.h"
    … …  
    106108INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PROGRESS_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    107109INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
     110INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    108111
    109112

  • trunk/Source/WebCore/dom/HashChangeEvent.idl

    r94962 r95063  
    2323    interface [
    2424        CanBeConstructed,
    25         CustomConstructFunction
     25        CustomConstructFunction,
     26        V8CustomConstructor
    2627    ] HashChangeEvent : Event {
    2728        void initHashChangeEvent(in [Optional=CallWithDefaultValue] DOMString type,
Note: See TracChangeset for help on using the changeset viewer.