Changeset 95085 in webkit

Timestamp:

Sep 14, 2011 2:48:59 AM (13 years ago)

Author:

jochen@chromium.org

Message:

[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
​https://bugs.webkit.org/show_bug.cgi?id=68066

Reviewed by Adam Barth.

• DumpRenderTree/chromium/WebViewHost.cpp:
• DumpRenderTree/chromium/WebViewHost.h:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/chromium/WebViewHost.cpp (modified) (2 diffs)
• DumpRenderTree/chromium/WebViewHost.h (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-14  Jochen Eisinger  <jochen@chromium.org>
+
+        [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
+        https://bugs.webkit.org/show_bug.cgi?id=68066
+
+        Reviewed by Adam Barth.
+
+        * DumpRenderTree/chromium/WebViewHost.cpp:
+        * DumpRenderTree/chromium/WebViewHost.h:
+
 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp

@@ -795 +795 @@
 }
 
-bool WebViewHost::allowPlugins(WebFrame* frame, bool enabledPerSettings)
-{
-    return enabledPerSettings;
-}
-
-bool WebViewHost::allowImages(WebFrame* frame, bool enabledPerSettings)
-{
-    return enabledPerSettings;
-}
-
 void WebViewHost::loadURLExternally(WebFrame* frame, const WebURLRequest& request, WebNavigationPolicy policy)
 {
@@ -1145 +1135 @@
     if (m_shell->shouldDumpFrameLoadCallbacks())
         fputs("didRunInsecureContent\n", stdout);
-}
-
-bool WebViewHost::allowScript(WebFrame*, bool enabledPerSettings)
-{
-    return enabledPerSettings;
 }
 

trunk/Tools/DumpRenderTree/chromium/WebViewHost.h

@@ -172 +172 @@
     virtual WebKit::WebMediaPlayer* createMediaPlayer(WebKit::WebFrame*, WebKit::WebMediaPlayerClient*);
     virtual WebKit::WebApplicationCacheHost* createApplicationCacheHost(WebKit::WebFrame*, WebKit::WebApplicationCacheHostClient*);
-     virtual bool allowPlugins(WebKit::WebFrame*, bool enabledPerSettings);
-    virtual bool allowImages(WebKit::WebFrame*, bool enabledPerSettings);
     virtual void loadURLExternally(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationPolicy);
     virtual void loadURLExternally(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationPolicy, const WebKit::WebString& downloadName);
@@ -209 +207 @@
     virtual void didDisplayInsecureContent(WebKit::WebFrame*);
     virtual void didRunInsecureContent(WebKit::WebFrame*, const WebKit::WebSecurityOrigin&, const WebKit::WebURL&);
-    virtual bool allowScript(WebKit::WebFrame*, bool enabledPerSettings);
     virtual void openFileSystem(WebKit::WebFrame*, WebKit::WebFileSystem::Type, long long size, bool create, WebKit::WebFileSystemCallbacks*);