Changeset 95130 in webkit


Ignore:
Timestamp:
Sep 14, 2011 3:31:40 PM (13 years ago)
Author:
andersca@apple.com
Message:

Get rid of WebCoreViewFactory and its WebViewFactory subclass
https://bugs.webkit.org/show_bug.cgi?id=68124

Reviewed by Sam Weinig.

../WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/mac/FrameSelectionMac.mm:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreViewFactory.h: Removed.
  • page/mac/WebCoreViewFactory.m: Removed.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebViewFactory.h: Removed.
  • WebCoreSupport/WebViewFactory.mm: Removed.
  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]):

Location:
trunk/Source
Files:
4 deleted
10 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r95129 r95130  
     12011-09-14  Anders Carlsson  <andersca@apple.com>
     2
     3        Get rid of WebCoreViewFactory and its WebViewFactory subclass
     4        https://bugs.webkit.org/show_bug.cgi?id=68124
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebCore.exp.in:
     9        * WebCore.xcodeproj/project.pbxproj:
     10        * editing/mac/FrameSelectionMac.mm:
     11        * page/mac/FrameMac.mm:
     12        * page/mac/WebCoreViewFactory.h: Removed.
     13        * page/mac/WebCoreViewFactory.m: Removed.
     14
    1152011-09-14  David Hyatt  <hyatt@apple.com>
    216
  • trunk/Source/WebCore/WebCore.exp.in

    r95108 r95130  
    106106.objc_class_name_DOMUIEvent
    107107.objc_class_name_DOMWheelEvent
    108 .objc_class_name_WebCoreViewFactory
    109108.objc_class_name_WebFontCache
    110109.objc_class_name_WebHTMLConverter
  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r95128 r95130  
    31223122                93F1998C08245E59001E9ABC /* RenderTreeAsText.h in Headers */ = {isa = PBXBuildFile; fileRef = 93955A4103D72932008635CE /* RenderTreeAsText.h */; settings = {ATTRIBUTES = (Private, ); }; };
    31233123                93F199A808245E59001E9ABC /* WebCoreFrameView.h in Headers */ = {isa = PBXBuildFile; fileRef = F587854C02DE375901EA4122 /* WebCoreFrameView.h */; settings = {ATTRIBUTES = (Private, ); }; };
    3124                 93F199B308245E59001E9ABC /* WebCoreViewFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = F587855402DE375901EA4122 /* WebCoreViewFactory.h */; settings = {ATTRIBUTES = (Private, ); }; };
    31253124                93F199B808245E59001E9ABC /* Scrollbar.h in Headers */ = {isa = PBXBuildFile; fileRef = BC7B2AF80450824100A8000F /* Scrollbar.h */; settings = {ATTRIBUTES = (Private, ); }; };
    31263125                93F199BB08245E59001E9ABC /* WebCoreKeyboardUIMode.h in Headers */ = {isa = PBXBuildFile; fileRef = BE983D95052A2E0A00892D85 /* WebCoreKeyboardUIMode.h */; settings = {ATTRIBUTES = (Private, ); }; };
     
    31333132                93F199F008245E59001E9ABC /* WebCoreView.h in Headers */ = {isa = PBXBuildFile; fileRef = BE855F7F0701E83500239769 /* WebCoreView.h */; settings = {ATTRIBUTES = (Private, ); }; };
    31343133                93F19A2608245E59001E9ABC /* CursorMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = F58784F002DE375901EA4122 /* CursorMac.mm */; };
    3135                 93F19A5F08245E59001E9ABC /* WebCoreViewFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = F587855502DE375901EA4122 /* WebCoreViewFactory.m */; };
    31363134                93F19A9108245E59001E9ABC /* HTMLDocument.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F523D23B02DE4396018635CA /* HTMLDocument.cpp */; };
    31373135                93F19A9208245E59001E9ABC /* HTMLElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F523D23E02DE4396018635CA /* HTMLElement.cpp */; };
     
    1257612574                F58784F002DE375901EA4122 /* CursorMac.mm */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = CursorMac.mm; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    1257712575                F587854C02DE375901EA4122 /* WebCoreFrameView.h */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreFrameView.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    12578                 F587855402DE375901EA4122 /* WebCoreViewFactory.h */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreViewFactory.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    12579                 F587855502DE375901EA4122 /* WebCoreViewFactory.m */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.objc; path = WebCoreViewFactory.m; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    1258012576                F587863A02DE3A1401EA4122 /* Settings.h */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = Settings.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    1258112577                F587864902DE3A9A01EA4122 /* CachePolicy.h */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = CachePolicy.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
     
    1614416140                                1C26497B0D7E24EC00BD10F2 /* PageMac.cpp */,
    1614516141                                F587854C02DE375901EA4122 /* WebCoreFrameView.h */,
    16146                                 F587855402DE375901EA4122 /* WebCoreViewFactory.h */,
    16147                                 F587855502DE375901EA4122 /* WebCoreViewFactory.m */,
    1614816142                        );
    1614916143                        path = mac;
     
    2334623340                                37F818FD0D657606005E1F05 /* WebCoreURLResponse.h in Headers */,
    2334723341                                93F199F008245E59001E9ABC /* WebCoreView.h in Headers */,
    23348                                 93F199B308245E59001E9ABC /* WebCoreViewFactory.h in Headers */,
    2334923342                                BC6DADEF0A195FDF00E5CD14 /* WebFontCache.h in Headers */,
    2335023343                                A7D20F6D107F438B00A80392 /* WebGLActiveInfo.h in Headers */,
     
    2618726180                                37F818FE0D657606005E1F05 /* WebCoreURLResponse.mm in Sources */,
    2618826181                                93F19B0708245E59001E9ABC /* WebCoreView.m in Sources */,
    26189                                 93F19A5F08245E59001E9ABC /* WebCoreViewFactory.m in Sources */,
    2619026182                                BC6DADFA0A19602B00E5CD14 /* WebFontCache.mm in Sources */,
    2619126183                                49C7B9C81042D32F0009D447 /* WebGLBuffer.cpp in Sources */,
  • trunk/Source/WebCore/editing/mac/FrameSelectionMac.mm

    r93273 r95130  
    3030#import "Frame.h"
    3131#import "RenderView.h"
    32 #import "WebCoreViewFactory.h"
    3332
    3433namespace WebCore {
  • trunk/Source/WebCore/page/mac/FrameMac.mm

    r94427 r95130  
    5151#import "Scrollbar.h"
    5252#import "SimpleFontData.h"
    53 #import "WebCoreViewFactory.h"
    5453#import "visible_units.h"
    55 #import <Carbon/Carbon.h>
    5654#import <wtf/StdLibExtras.h>
    5755
  • trunk/Source/WebKit/ChangeLog

    r93637 r95130  
     12011-09-14  Anders Carlsson  <andersca@apple.com>
     2
     3        Get rid of WebCoreViewFactory and its WebViewFactory subclass
     4        https://bugs.webkit.org/show_bug.cgi?id=68124
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebKit.xcodeproj/project.pbxproj:
     9
    1102011-08-23  Jonas M. Gastal <jgastal@profusion.mobi>
    211
  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r92492 r95130  
    177177                9398103A0824BF01008DF038 /* WebPluginViewFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 848DFF860365FE6A00CA2ACA /* WebPluginViewFactory.h */; settings = {ATTRIBUTES = (Public, ); }; };
    178178                939810420824BF01008DF038 /* WebJavaScriptTextInputPanel.h in Headers */ = {isa = PBXBuildFile; fileRef = 9345D4EA0365C5B2008635CE /* WebJavaScriptTextInputPanel.h */; settings = {ATTRIBUTES = (Private, ); }; };
    179                 939810460824BF01008DF038 /* WebViewFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = F5F7174C02885C5B018635CA /* WebViewFactory.h */; settings = {ATTRIBUTES = (); }; };
    180179                939810470824BF01008DF038 /* WebKitPrefix.h in Headers */ = {isa = PBXBuildFile; fileRef = F5C283730284676D018635CA /* WebKitPrefix.h */; };
    181180                939810490824BF01008DF038 /* WebClipView.h in Headers */ = {isa = PBXBuildFile; fileRef = 933D659903413FF2008635CE /* WebClipView.h */; };
     
    273272                939810E30824BF01008DF038 /* WebImageRendererFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = 9CE1F8A302A5C6F30ECA2ACD /* WebImageRendererFactory.m */; };
    274273                939810E40824BF01008DF038 /* WebJavaScriptTextInputPanel.m in Sources */ = {isa = PBXBuildFile; fileRef = 9345D4EB0365C5B2008635CE /* WebJavaScriptTextInputPanel.m */; };
    275                 939810E80824BF01008DF038 /* WebViewFactory.mm in Sources */ = {isa = PBXBuildFile; fileRef = F5F7174D02885C5B018635CA /* WebViewFactory.mm */; };
    276274                939810EB0824BF01008DF038 /* WebClipView.mm in Sources */ = {isa = PBXBuildFile; fileRef = 933D659A03413FF2008635CE /* WebClipView.mm */; };
    277275                939810ED0824BF01008DF038 /* WebDataSource.mm in Sources */ = {isa = PBXBuildFile; fileRef = 39446071020F50ED0ECA1767 /* WebDataSource.mm */; };
     
    739737                F5F717210288493C018635CA /* WebPluginDatabase.mm */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.objcpp; fileEncoding = 4; indentWidth = 4; path = WebPluginDatabase.mm; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    740738                F5F717230288493C018635CA /* npapi.mm */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.objcpp; fileEncoding = 4; indentWidth = 4; path = npapi.mm; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    741                 F5F7174C02885C5B018635CA /* WebViewFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebViewFactory.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    742                 F5F7174D02885C5B018635CA /* WebViewFactory.mm */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebViewFactory.mm; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
    743739                F5F732D202FF4D4F01A80180 /* WebKit.exp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.exports; name = WebKit.exp; path = mac/WebKit.exp; sourceTree = "<group>"; tabWidth = 4; usesTabs = 0; };
    744740                F5F81C3902B67C26018635CA /* WebRenderNode.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebRenderNode.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
     
    13241320                                93EB178E09F88D510091F8FF /* WebSystemInterface.h */,
    13251321                                93EB178C09F88D460091F8FF /* WebSystemInterface.mm */,
    1326                                 F5F7174C02885C5B018635CA /* WebViewFactory.h */,
    1327                                 F5F7174D02885C5B018635CA /* WebViewFactory.mm */,
    13281322                        );
    13291323                        name = WebCoreSupport;
     
    16061600                                939810700824BF01008DF038 /* WebView.h in Headers */,
    16071601                                BC2E464D0FD8A96800A9D9DE /* WebViewData.h in Headers */,
    1608                                 939810460824BF01008DF038 /* WebViewFactory.h in Headers */,
    16091602                                9398109B0824BF01008DF038 /* WebViewInternal.h in Headers */,
    16101603                                939810710824BF01008DF038 /* WebViewPrivate.h in Headers */,
     
    19831976                                BC2E464E0FD8A96800A9D9DE /* WebViewData.mm in Sources */,
    19841977                                BC97E7E210963D260010D361 /* WebViewEventHandling.mm in Sources */,
    1985                                 939810E80824BF01008DF038 /* WebViewFactory.mm in Sources */,
    19861978                                41F4485010338E8C0030E55E /* WebWorkersPrivate.mm in Sources */,
    19871979                                A5DEFC0A11D5331C00885273 /* WebSecurityOrigin.mm in Sources */,
  • trunk/Source/WebKit/mac/ChangeLog

    r95108 r95130  
     12011-09-14  Anders Carlsson  <andersca@apple.com>
     2
     3        Get rid of WebCoreViewFactory and its WebViewFactory subclass
     4        https://bugs.webkit.org/show_bug.cgi?id=68124
     5
     6        Reviewed by Sam Weinig.
     7
     8        * WebCoreSupport/WebContextMenuClient.mm:
     9        * WebCoreSupport/WebViewFactory.h: Removed.
     10        * WebCoreSupport/WebViewFactory.mm: Removed.
     11        * WebView/WebFrameView.mm:
     12        (-[WebFrameView initWithFrame:]):
     13
    1142011-09-14  Mark Hahnenberg  <mhahnenberg@apple.com>
    215
  • trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm

    r93268 r95130  
    4040#import "WebUIDelegatePrivate.h"
    4141#import "WebView.h"
    42 #import "WebViewFactory.h"
    4342#import "WebViewInternal.h"
    4443#import <WebCore/ContextMenu.h>
  • trunk/Source/WebKit/mac/WebView/WebFrameView.mm

    r90380 r95130  
    5252#import "WebResourceInternal.h"
    5353#import "WebSystemInterface.h"
    54 #import "WebViewFactory.h"
    5554#import "WebViewInternal.h"
    5655#import "WebViewPrivate.h"
     
    319318        WebCore::notifyHistoryItemChanged = WKNotifyHistoryItemChanged;
    320319
    321         [WebViewFactory createSharedFactory];
    322 
    323320// FIXME: Remove the NSAppKitVersionNumberWithDeferredWindowDisplaySupport check once
    324321// once AppKit's Deferred Window Display support is available.
Note: See TracChangeset for help on using the changeset viewer.