Changeset 95154 in webkit

Timestamp:

Sep 14, 2011 7:53:13 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Eliminate WebKit2 compilation warnings.
​https://bugs.webkit.org/show_bug.cgi?id=65025

Warnings found with gcc on linux.

Patch by Wajahat Siddiqui <​mdwajahatali.siddiqui@motorola.com> on 2011-09-14
Reviewed by Sam Weinig.

• Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Platform/CoreIPC/ArgumentEncoder.cpp (modified) (1 diff)
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-09-14  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
+
+        Eliminate WebKit2 compilation warnings.
+        https://bugs.webkit.org/show_bug.cgi?id=65025
+
+        Warnings found with gcc on linux.
+
+        Reviewed by Sam Weinig.
+
+        * Platform/CoreIPC/ArgumentEncoder.cpp:
+        (CoreIPC::ArgumentEncoder::~ArgumentEncoder):
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::createPlugin):
+
 2011-09-14  Ada Chan  <adachan@apple.com>
 

trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp

@@ -55 +55 @@
     // FIXME: We need to dispose of the attachments in cases of failure.
 #else
-    for (int i = 0; i < m_attachments.size(); ++i)
+    for (size_t i = 0; i < m_attachments.size(); ++i)
         m_attachments[i].dispose();
 #endif

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -1267 +1267 @@
         // Inject wmode=opaque to make Flash work in these conditions.
         size_t wmodeIndex = parameters.names.find("wmode");
-        if (wmodeIndex == -1) {
+        if (wmodeIndex == notFound) {
             parameters.names.append("wmode");
             parameters.values.append("opaque");