Changeset 95157 in webkit

Timestamp:

Sep 14, 2011 8:28:43 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[v8] Improve performance of typed array copy constructor taking Array
​https://bugs.webkit.org/show_bug.cgi?id=68015

Patch by Ulan Degenbaev <​ulan@chromium.org> on 2011-09-14
Reviewed by Kenneth Russell.

Invoke the 'set' method of the constructed array instead of
copying the elements of the source array one by one.

Copy constructor tests already exist.

• ../../Source/WebCore/WebCore.gypi:
• ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
• ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/WebCore.gypi (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (added)
• Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (modified) (4 diffs)

trunk/ChangeLog

@@ +1 @@
+2011-09-14  Ulan Degenbaev  <ulan@chromium.org>
+
+        [v8] Improve performance of typed array copy constructor taking Array
+        https://bugs.webkit.org/show_bug.cgi?id=68015
+
+        Reviewed by Kenneth Russell.
+
+        Invoke the 'set' method of the constructed array instead of
+        copying the elements of the source array one by one.
+
+        Copy constructor tests already exist.
+
+        * ../../Source/WebCore/WebCore.gypi:
+        * ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
+        * ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
+
 2011-09-14  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/WebCore.gypi

@@ -2117 +2117 @@
             'bindings/v8/WrapperTypeInfo.h',
             'bindings/v8/custom/V8ArrayBufferCustom.cpp',
+            'bindings/v8/custom/V8ArrayBufferViewCustom.cpp',
             'bindings/v8/custom/V8ArrayBufferViewCustom.h',
             'bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp',

trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -33 +33 @@
 
 #include "ArrayBuffer.h"
+#include "ExceptionCode.h"
 
 #include "V8ArrayBuffer.h"
@@ -39 +40 @@
 
 namespace WebCore {
+
+
+// Copy the elements from the source array to the typed destination array by
+// invoking the 'set' method of the destination array in JS.
+void copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray);
 
 // Template function used by the ArrayBufferView*Constructor callbacks.
@@ -148 +154 @@
         return throwError("ArrayBufferView size is not a small enough positive integer.", V8Proxy::RangeError);
 
-    if (!srcArray.IsEmpty()) {
-        // Need to copy the incoming array into the newly created ArrayBufferView.
-        for (unsigned i = 0; i < len; i++) {
-            v8::Local<v8::Value> val = srcArray->Get(i);
-            array->set(i, val->NumberValue());
-        }
-    }
 
     // Transform the holder into a wrapper object for the array.
     V8DOMWrapper::setDOMWrapper(args.Holder(), type, array.get());
     args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
+
+    if (!srcArray.IsEmpty())
+        copyElements(args.Holder(), srcArray);
+
     return toV8(array.release(), args.Holder(), MarkIndependent);
 }