Changeset 95226 in webkit

Timestamp:

Sep 15, 2011 2:04:09 PM (13 years ago)

Author:

jonlee@apple.com

Message:

Submitting a form with target=_blank works only once
​https://bugs.webkit.org/show_bug.cgi?id=28633
<rdar://problem/7357787>

Reviewed by Andy Estes.

Source/WebCore:

Test: fast/forms/submit-to-blank-multiple-times.html

The call to reset the multiple form submission bool is pushed down from the mouseDown handler to
handleMousePressEvent(), to include WK2 coverage, similar to keyEvent.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent): clarified old FIXME comment. Both key events and mouse events
may submit a form multiple times, but the call to reset the handler should probably be in another
abstraction layer.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::mouseDown):

Source/WebKit/chromium:

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::mouseDown): Remove call to resetMultipleFormSubmissionProtection() since
it will be made in platform-independent function EventHandler::handleMousePressEvent().

LayoutTests:

New test that simulates mouse clicking submit button twice (which didn't work), as well as using the keyboard twice (which did work).

• fast/forms/resources/submit-to-blank-multiple-times-form-action.html: Added.
• fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
• fast/forms/submit-to-blank-multiple-times.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/resources/submit-to-blank-multiple-times-form-action.html (added)
• LayoutTests/fast/forms/submit-to-blank-multiple-times-expected.txt (added)
• LayoutTests/fast/forms/submit-to-blank-multiple-times.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/EventHandler.cpp (modified) (2 diffs)
• Source/WebCore/page/mac/EventHandlerMac.mm (modified) (1 diff)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/src/WebViewImpl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-15  Jon Lee  <jonlee@apple.com>
+
+        Submitting a form with target=_blank works only once
+        https://bugs.webkit.org/show_bug.cgi?id=28633
+        <rdar://problem/7357787>
+
+        Reviewed by Andy Estes.
+
+        New test that simulates mouse clicking submit button twice (which didn't work), as well as using the keyboard twice (which did work).
+
+        * fast/forms/resources/submit-to-blank-multiple-times-form-action.html: Added.
+        * fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
+        * fast/forms/submit-to-blank-multiple-times.html: Added.
+
 2011-09-15  David Levin  <levin@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-15  Jon Lee  <jonlee@apple.com>
+
+        Submitting a form with target=_blank works only once
+        https://bugs.webkit.org/show_bug.cgi?id=28633
+        <rdar://problem/7357787>
+
+        Reviewed by Andy Estes.
+
+        Test: fast/forms/submit-to-blank-multiple-times.html
+
+        The call to reset the multiple form submission bool is pushed down from the mouseDown handler to
+        handleMousePressEvent(), to include WK2 coverage, similar to keyEvent.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMousePressEvent):
+        (WebCore::EventHandler::keyEvent): clarified old FIXME comment. Both key events and mouse events
+        may submit a form multiple times, but the call to reset the handler should probably be in another
+        abstraction layer.
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::mouseDown):
+
 2011-09-15  Peter Rybin  <peter.rybin@gmail.com>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -1342 +1342 @@
     UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
 
+    // FIXME (bug 68185): this call should be made at another abstraction layer
+    m_frame->loader()->resetMultipleFormSubmissionProtection();
+    
     cancelFakeMouseMoveEvent();
     m_mousePressed = true;
@@ -2519 +2522 @@
         view->resetDeferredRepaintDelay();
 
-    // FIXME: what is this doing here, in keyboard event handler?
+    // FIXME (bug 68185): this call should be made at another abstraction layer
     m_frame->loader()->resetMultipleFormSubmissionProtection();
 

trunk/Source/WebCore/page/mac/EventHandlerMac.mm

@@ -479 +479 @@
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
     
-    m_frame->loader()->resetMultipleFormSubmissionProtection();
-
     m_mouseDownView = nil;
     

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-15  Jon Lee  <jonlee@apple.com>
+
+        Submitting a form with target=_blank works only once
+        https://bugs.webkit.org/show_bug.cgi?id=28633
+        <rdar://problem/7357787>
+
+        Reviewed by Andy Estes.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::mouseDown): Remove call to resetMultipleFormSubmissionProtection() since
+        it will be made in platform-independent function EventHandler::handleMousePressEvent().
+
 2011-09-15  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -476 +476 @@
     }
 
-    mainFrameImpl()->frame()->loader()->resetMultipleFormSubmissionProtection();
-
     mainFrameImpl()->frame()->eventHandler()->handleMousePressEvent(
         PlatformMouseEventBuilder(mainFrameImpl()->frameView(), event));