Changeset 95247 in webkit

Timestamp:

Sep 15, 2011 5:39:34 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Python version check is confusing in test-webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=68004

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-15
Reviewed by Adam Barth.

• Scripts/test-webkitpy:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/test-webkitpy (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
+
+        Python version check is confusing in test-webkitpy
+        https://bugs.webkit.org/show_bug.cgi?id=68004
+
+        Reviewed by Adam Barth.
+
+        * Scripts/test-webkitpy:
+
 2011-09-15  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/test-webkitpy

@@ -217 +217 @@
     versioning.check_version(log=_log)
 
-    (comparison, current_version, minimum_version) = \
+    (comparison, current_version, expected_version) = \
         versioning.compare_version()
 
-    if comparison > 0:
-        # Then the current version is later than the minimum version.
-        message = ("You are testing webkitpy with a Python version (%s) "
-                   "higher than the minimum version (%s) it was meant "
-                   "to support." % (current_version, minimum_version))
+    if comparison != 0:
+        # Then the current version is not what we expect.
+        message = ("You are testing webkitpy with Python version (%s) "
+                   "instead of version (%s) which we support.  Please verify "
+                   "changes against version (%s)" % (current_version, expected_version, expected_version))
         _log.warn(message)
-
 
 def _path_from_webkit_root(*components):