Changeset 95363 in webkit

Timestamp:

Sep 16, 2011 9:15:13 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

update-webkit-chromium should retry the gclient call if it fails once
​https://bugs.webkit.org/show_bug.cgi?id=68252

Patch by Tom Zakrajsek <​tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.

• Scripts/update-webkit-chromium:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/update-webkit-chromium (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
+
+        update-webkit-chromium should retry the gclient call if it fails once
+        https://bugs.webkit.org/show_bug.cgi?id=68252
+
+        Reviewed by Adam Barth.
+
+        * Scripts/update-webkit-chromium:
+
 2011-09-16  Rob Buis  <rbuis@rim.com>
 

trunk/Tools/Scripts/update-webkit-chromium

@@ -78 +78 @@
 push @gclientArgs, "--delete_unversioned_trees" if $force;
 push @gclientArgs, "--deps=unix,android" if isChromiumAndroid();
-system(@gclientArgs) == 0 or die $!;
+
+my $cmd = join(" ",@gclientArgs);
+my $max_attempts = 3;
+my $rc = -1;
+
+# The following will call glient up to $max_attempts times before
+# it gives up and fails.  We need this because glcient can fail
+# for several reasons, some of which are transient (flakiness).
+
+for (1 .. $max_attempts) {
+    $rc = system($cmd);
+    print "Re-trying '" . $cmd . "'\n" if $rc != 0;
+    last if $rc == 0;
+}
+
+die "Error: '$cmd' failed $max_attempts tries and returned " . $rc if ($rc);