Changeset 95387 in webkit


Ignore:
Timestamp:
Sep 17, 2011 4:31:52 PM (13 years ago)
Author:
mihaip@chromium.org
Message:

FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • history/BackForwardListImpl.cpp:

(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:
  • WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Location:
trunk/Source
Files:
35 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r95386 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only
     9        the old (since-deleted) Android port needed them.
     10
     11        * history/BackForwardListImpl.cpp:
     12        (WebCore::BackForwardListImpl::addItem):
     13        (WebCore::BackForwardListImpl::goBack):
     14        (WebCore::BackForwardListImpl::goForward):
     15        (WebCore::BackForwardListImpl::goToItem):
     16        (WebCore::BackForwardListImpl::setCapacity):
     17        * loader/EmptyClients.h:
     18        * loader/FrameLoaderClient.h:
     19
    1202011-09-17  David Hyatt  <hyatt@apple.com>
    221
  • trunk/Source/WebCore/history/BackForwardListImpl.cpp

    r85256 r95387  
    8383        pageCache()->remove(item.get());
    8484        m_current--;
    85         if (m_page)
    86             m_page->mainFrame()->loader()->client()->dispatchDidRemoveBackForwardItem(item.get());
    8785    }
    8886
     
    9088    m_entries.insert(m_current + 1, prpItem);
    9189    m_current++;
    92     if (m_page)
    93         m_page->mainFrame()->loader()->client()->dispatchDidAddBackForwardItem(currentItem());
    9490}
    9591
     
    9995    if (m_current > 0) {
    10096        m_current--;
    101         if (m_page)
    102             m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
    10397    }
    10498}
     
    109103    if (m_current < m_entries.size() - 1) {
    110104        m_current++;
    111         if (m_page)
    112             m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
    113105    }
    114106}
     
    125117    if (index < m_entries.size()) {
    126118        m_current = index;
    127         if (m_page)
    128             m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
    129119    }
    130120}
     
    195185    else if (m_current > m_entries.size() - 1) {
    196186        m_current = m_entries.size() - 1;
    197         if (m_page)
    198             m_page->mainFrame()->loader()->client()->dispatchDidChangeBackForwardIndex();
    199187    }
    200188    m_capacity = size;
  • trunk/Source/WebCore/loader/EmptyClients.h

    r95385 r95387  
    368368    virtual bool shouldGoToHistoryItem(HistoryItem*) const { return false; }
    369369    virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const { return false; }
    370     virtual void dispatchDidAddBackForwardItem(HistoryItem*) const { }
    371     virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const { }
    372     virtual void dispatchDidChangeBackForwardIndex() const { }
    373370    virtual void updateGlobalHistoryItemForPage() { }
    374371    virtual void saveViewStateToItem(HistoryItem*) { }
  • trunk/Source/WebCore/loader/FrameLoaderClient.h

    r95385 r95387  
    3232#include "FrameLoaderTypes.h"
    3333#include "IconURL.h"
    34 #include "ScrollTypes.h"
    3534#include <wtf/Forward.h>
    3635#include <wtf/Vector.h>
     
    200199        virtual bool shouldGoToHistoryItem(HistoryItem*) const = 0;
    201200        virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const = 0;
    202         virtual void dispatchDidAddBackForwardItem(HistoryItem*) const = 0;
    203         virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const = 0;
    204         virtual void dispatchDidChangeBackForwardIndex() const = 0;
    205201        virtual void updateGlobalHistoryItemForPage() { }
    206202
  • trunk/Source/WebKit/chromium/ChangeLog

    r95385 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * src/FrameLoaderClientImpl.cpp:
     12        * src/FrameLoaderClientImpl.h:
     13
    1142011-09-17  Aaron Boodman  <aa@chromium.org>
    215
  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r95385 r95387  
    11841184}
    11851185
    1186 void FrameLoaderClientImpl::dispatchDidAddBackForwardItem(HistoryItem*) const
    1187 {
    1188 }
    1189 
    1190 void FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    1191 {
    1192 }
    1193 
    1194 void FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex() const
    1195 {
    1196 }
    1197 
    11981186void FrameLoaderClientImpl::didDisplayInsecureContent()
    11991187{
  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.h

    r95385 r95387  
    137137    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    138138    virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    139     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    140     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    141     virtual void dispatchDidChangeBackForwardIndex() const;
    142139    virtual void didDisplayInsecureContent();
    143140    virtual void didRunInsecureContent(WebCore::SecurityOrigin*, const WebCore::KURL& insecureURL);
  • trunk/Source/WebKit/efl/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/FrameLoaderClientEfl.cpp:
     12        * WebCoreSupport/FrameLoaderClientEfl.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

    r93813 r95387  
    170170}
    171171
    172 void FrameLoaderClientEfl::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
    173 {
    174     notImplemented();
    175 }
    176 
    177172void FrameLoaderClientEfl::dispatchDidPushStateWithinPage()
    178173{
     
    181176
    182177void FrameLoaderClientEfl::dispatchDidPopStateWithinPage()
    183 {
    184     notImplemented();
    185 }
    186 
    187 void FrameLoaderClientEfl::dispatchDidChangeBackForwardIndex() const
    188 {
    189     notImplemented();
    190 }
    191 
    192 void FrameLoaderClientEfl::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
    193178{
    194179    notImplemented();
  • trunk/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.h

    r93572 r95387  
    8282    virtual void dispatchDidPopStateWithinPage();
    8383    virtual void dispatchDidReplaceStateWithinPage();
    84     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    85     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    86     virtual void dispatchDidChangeBackForwardIndex() const;
    8784    virtual void dispatchDidClearWindowObjectInWorld(WebCore::DOMWrapperWorld*);
    8885
  • trunk/Source/WebKit/gtk/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/FrameLoaderClientGtk.cpp:
     12        * WebCoreSupport/FrameLoaderClientGtk.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

    r93066 r95387  
    714714}
    715715
    716 void FrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
    717 {
    718 }
    719 
    720 void FrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    721 {
    722 }
    723 
    724 void FrameLoaderClient::dispatchDidChangeBackForwardIndex() const
    725 {
    726 }
    727 
    728716void FrameLoaderClient::didDisplayInsecureContent()
    729717{
  • trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h

    r93066 r95387  
    143143        virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    144144        virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    145         virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    146         virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    147         virtual void dispatchDidChangeBackForwardIndex() const;
    148145
    149146        virtual void didDisplayInsecureContent();
  • trunk/Source/WebKit/haiku/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
     12        * WebCoreSupport/FrameLoaderClientHaiku.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp

    r93066 r95387  
    489489}
    490490
    491 void FrameLoaderClientHaiku::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
    492 {
    493 }
    494 
    495 void FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
    496 {
    497 }
    498 
    499 void FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex() const
    500 {
    501 }
    502 
    503491void FrameLoaderClientHaiku::saveScrollPositionAndViewStateToItem(WebCore::HistoryItem*)
    504492{
  • trunk/Source/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h

    r93066 r95387  
    161161        virtual bool shouldGoToHistoryItem(HistoryItem*) const;
    162162        virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
    163         virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
    164         virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
    165         virtual void dispatchDidChangeBackForwardIndex() const;
    166163        virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
    167164        virtual bool canCachePage() const;
  • trunk/Source/WebKit/mac/ChangeLog

    r95347 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/WebFrameLoaderClient.h:
     12        * WebCoreSupport/WebFrameLoaderClient.mm:
     13        * WebKit.order:
     14
    1152011-09-16  Simon Fraser  <simon.fraser@apple.com>
    216
  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h

    r93066 r95387  
    153153    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    154154    virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    155     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    156     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    157     virtual void dispatchDidChangeBackForwardIndex() const;
    158155    virtual void updateGlobalHistoryItemForPage();
    159156
  • trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm

    r93268 r95387  
    974974}
    975975
    976 void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
    977 {
    978 }
    979 
    980 void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    981 {
    982 }
    983 
    984 void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
    985 {
    986 }
    987 
    988976void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
    989977{
  • trunk/Source/WebKit/mac/WebKit.order

    r88833 r95387  
    739739-[WebHTMLRepresentation setDataSource:]
    740740__Z26WKNotifyHistoryItemChangedPN7WebCore11HistoryItemE
    741 __ZNK20WebFrameLoaderClient29dispatchDidAddBackForwardItemEPN7WebCore11HistoryItemE
    742741__ZN20WebFrameLoaderClient19updateGlobalHistoryEv
    743742-[WebView(WebPendingPublic) historyDelegate]
     
    12211220_WKExecutableWasLinkedOnOrBeforeSnowLeopard
    12221221+[WebCoreStatistics garbageCollectJavaScriptObjects]
    1223 __ZNK20WebFrameLoaderClient32dispatchDidRemoveBackForwardItemEPN7WebCore11HistoryItemE
    12241222__ZNK7WebCore12ChromeClient29dispatchViewportDataDidChangeERKNS_17ViewportArgumentsE
    12251223-[WebView(WebPrivate) setFrameSize:]
     
    17571755__ZNK20WebFrameLoaderClient21shouldGoToHistoryItemEPN7WebCore11HistoryItemE
    17581756-[WebDefaultPolicyDelegate webView:shouldGoToHistoryItem:]
    1759 __ZNK20WebFrameLoaderClient33dispatchDidChangeBackForwardIndexEv
    17601757-[WebView(WebPendingPublic) zoomPageOut:]
    17611758-[WebView _zoomOut:isTextOnly:]
  • trunk/Source/WebKit/qt/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/FrameLoaderClientQt.cpp:
     12        * WebCoreSupport/FrameLoaderClientQt.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

    r95055 r95387  
    855855}
    856856
    857 void FrameLoaderClientQt::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
    858 {
    859 }
    860 
    861 void FrameLoaderClientQt::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
    862 {
    863 }
    864 
    865 void FrameLoaderClientQt::dispatchDidChangeBackForwardIndex() const
    866 {
    867 }
    868 
    869857void FrameLoaderClientQt::didDisplayInsecureContent()
    870858{
  • trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h

    r94105 r95387  
    161161    virtual bool shouldGoToHistoryItem(HistoryItem*) const;
    162162    virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
    163     virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
    164     virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
    165     virtual void dispatchDidChangeBackForwardIndex() const;
    166163    virtual void didDisplayInsecureContent();
    167164    virtual void didRunInsecureContent(SecurityOrigin*, const KURL&);
  • trunk/Source/WebKit/win/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/WebFrameLoaderClient.cpp:
     12        * WebCoreSupport/WebFrameLoaderClient.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp

    r93066 r95387  
    614614}
    615615
    616 void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
    617 {
    618 }
    619 
    620 void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    621 {
    622 }
    623 
    624 void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
    625 {
    626 }
    627 
    628616void WebFrameLoaderClient::updateGlobalHistoryItemForPage()
    629617{
  • trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h

    r93066 r95387  
    9595    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    9696    virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    97     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    98     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    99     virtual void dispatchDidChangeBackForwardIndex() const;
    10097    virtual void updateGlobalHistoryItemForPage();
    10198
  • trunk/Source/WebKit/wince/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
     12        * WebCoreSupport/FrameLoaderClientWinCE.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.cpp

    r93066 r95387  
    265265}
    266266
    267 void FrameLoaderClientWinCE::dispatchDidAddBackForwardItem(HistoryItem*) const
    268 {
    269 }
    270 
    271 void FrameLoaderClientWinCE::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    272 {
    273 }
    274 
    275 void FrameLoaderClientWinCE::dispatchDidChangeBackForwardIndex() const
    276 {
    277 }
    278 
    279267void FrameLoaderClientWinCE::didDisplayInsecureContent()
    280268{
  • trunk/Source/WebKit/wince/WebCoreSupport/FrameLoaderClientWinCE.h

    r93066 r95387  
    138138    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    139139    virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    140     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    141     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    142     virtual void dispatchDidChangeBackForwardIndex() const;
    143140
    144141    virtual void didDisplayInsecureContent();
  • trunk/Source/WebKit/wx/ChangeLog

    r95271 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebKitSupport/FrameLoaderClientWx.cpp:
     12        * WebKitSupport/FrameLoaderClientWx.h:
     13
    1142011-09-15  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.cpp

    r93066 r95387  
    593593}
    594594
    595 void FrameLoaderClientWx::dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const
    596 {
    597 }
    598 
    599 void FrameLoaderClientWx::dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const
    600 {
    601 }
    602 
    603 void FrameLoaderClientWx::dispatchDidChangeBackForwardIndex() const
    604 {
    605 }
    606 
    607595void FrameLoaderClientWx::didDisplayInsecureContent()
    608596{
  • trunk/Source/WebKit/wx/WebKitSupport/FrameLoaderClientWx.h

    r93066 r95387  
    166166        virtual bool shouldGoToHistoryItem(HistoryItem*) const;
    167167        virtual bool shouldStopLoadingForHistoryItem(HistoryItem*) const;
    168         virtual void dispatchDidAddBackForwardItem(HistoryItem*) const;
    169         virtual void dispatchDidRemoveBackForwardItem(HistoryItem*) const;
    170         virtual void dispatchDidChangeBackForwardIndex() const;
    171168        virtual void saveScrollPositionAndViewStateToItem(HistoryItem*);
    172169        virtual bool canCachePage() const;
  • trunk/Source/WebKit2/ChangeLog

    r95367 r95387  
     12011-09-17  Mihai Parparita  <mihaip@chromium.org>
     2
     3        FrameLoaderClient BackForwardList-related methods are unsued
     4        https://bugs.webkit.org/show_bug.cgi?id=68293
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove FrameLoaderClient methods that were added by r51629, since only       
     9        the old (since-deleted) Android port needed them.
     10
     11        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
     12        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
     13
    1142011-09-16  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
    215        [Qt] QTouchWebView missing loadProgress tests
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r95154 r95387  
    924924}
    925925
    926 void WebFrameLoaderClient::dispatchDidAddBackForwardItem(HistoryItem*) const
    927 {
    928     notImplemented();
    929 }
    930 
    931 void WebFrameLoaderClient::dispatchDidRemoveBackForwardItem(HistoryItem*) const
    932 {
    933     notImplemented();
    934 }
    935 
    936 void WebFrameLoaderClient::dispatchDidChangeBackForwardIndex() const
    937 {
    938     notImplemented();
    939 }
    940 
    941926void WebFrameLoaderClient::didDisplayInsecureContent()
    942927{
  • trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h

    r93066 r95387  
    136136    virtual bool shouldGoToHistoryItem(WebCore::HistoryItem*) const;
    137137    virtual bool shouldStopLoadingForHistoryItem(WebCore::HistoryItem*) const;
    138     virtual void dispatchDidAddBackForwardItem(WebCore::HistoryItem*) const;
    139     virtual void dispatchDidRemoveBackForwardItem(WebCore::HistoryItem*) const;
    140     virtual void dispatchDidChangeBackForwardIndex() const;
    141138
    142139    virtual void didDisplayInsecureContent();
Note: See TracChangeset for help on using the changeset viewer.