Changeset 95441 in webkit

Timestamp:

Sep 19, 2011 11:03:06 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Buildbot marks a nrwt bot red when tests are missing results
​https://bugs.webkit.org/show_bug.cgi?id=64812

Patch by Kristóf Kosztyó <​kkristof@inf.u-szeged.hu> on 2011-09-19
Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/controllers/manager.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
+
+        Buildbot marks a nrwt bot red when tests are missing results
+        https://bugs.webkit.org/show_bug.cgi?id=64812
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/layout_tests/controllers/manager.py:
+        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+
 2011-09-19  Jessie Berlin  <jberlin@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -148 +148 @@
                     actual.append(keywords[retry_result_type])
                     num_flaky += 1
+                # FIXME: break MISSING results into a different category
+                elif 'MISSING' in actual:
+                    num_flaky += 1
                 else:
                     num_regressions += 1

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

@@ -716 +716 @@
         file_list = fs.written_files.keys()
         file_list.remove('/tmp/layout-test-results/tests_run0.txt')
-        self.assertEquals(res, 2)
+        self.assertEquals(res, 0)
         self.assertFalse(out.empty())
         self.assertEqual(len(file_list), 4)