Changeset 95549 in webkit

Timestamp:

Sep 20, 2011 9:45:34 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Changelog class should have a method to return all entries
​https://bugs.webkit.org/show_bug.cgi?id=68399

Implement ChangeLog.parse_entries_from_file(). This method returns a generator
of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.

Patch by Leandro Pereira <​leandro@profusion.mobi> on 2011-09-20
Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()

and adapt it to become a generator.

• Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/checkout/changelog.py (modified) (1 diff)
• Scripts/webkitpy/common/checkout/changelog_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
+
+        Changelog class should have a method to return all entries
+        https://bugs.webkit.org/show_bug.cgi?id=68399
+        
+        Implement ChangeLog.parse_entries_from_file(). This method returns a generator
+        of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
+
+        Reviewed by Ryosuke Niwa.
+
+        * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
+        and adapt it to become a generator.
+        * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
+
 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
 

trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py

@@ -160 +160 @@
             entry_lines.append(line)
         return None # We never found a date line!
+
+    @staticmethod
+    def parse_entries_from_file(changelog_file):
+        """changelog_file must be a file-like object which returns
+        unicode strings.  Use codecs.open or StringIO(unicode())
+        to pass file objects to this class."""
+        date_line_regexp = re.compile(ChangeLogEntry.date_line_regexp)
+        rolled_over_regexp = re.compile(ChangeLogEntry.rolled_over_regexp)
+        entry_lines = []
+        # The first line should be a date line.
+        first_line = changelog_file.readline()
+        assert(isinstance(first_line, unicode))
+        if not date_line_regexp.match(first_line):
+            raise StopIteration
+        entry_lines.append(first_line)
+
+        for line in changelog_file:
+            if date_line_regexp.match(line) or rolled_over_regexp.match(line):
+                # Remove the extra newline at the end
+                yield ChangeLogEntry(''.join(entry_lines[:-1]))
+                entry_lines = []
+            entry_lines.append(line)
 
     def latest_entry(self):

trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py

@@ -154 +154 @@
         self.assertEquals(57354, parse_bug_id_from_changelog(commit_text))
 
+    def test_parse_log_entries_from_changelog(self):
+        parsed_entries = list(ChangeLog.parse_entries_from_changelog(ChangeLogTest._example_changelog))
+        self.assertEquals(len(parsed_entries), 3)
+        self.assertEquals(parsed_entries[0].reviewer(), 'David Levin')
+        self.assertEquals(parsed_entries[1].author_email(), 'ddkilzer@apple.com')
+        self.assertEquals(parsed_entries[2].touched_files(), ['DumpRenderTree/mac/DumpRenderTreeWindow.mm'])
+
     def test_latest_entry_parse(self):
         changelog_contents = u"%s\n%s" % (self._example_entry, self._example_changelog)