Changeset 95629 in webkit

Timestamp:

Sep 21, 2011 7:58:15 AM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic command should explain that it is starting a local server
​https://bugs.webkit.org/show_bug.cgi?id=68486

Reviewed by Dimitri Glazkov.

In the user study, both participants didn't understand why the
garden-o-matic command appeared to hang. This patch adds an
explaination of what's going on. It also adds a confirmation prompt
before launching the browser to give the user a chance to read the
text. If that's too much of a speed bump, we can iterate.

• Scripts/webkitpy/tool/commands/gardenomatic.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/gardenomatic.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-21  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic command should explain that it is starting a local server
+        https://bugs.webkit.org/show_bug.cgi?id=68486
+
+        Reviewed by Dimitri Glazkov.
+
+        In the user study, both participants didn't understand why the
+        garden-o-matic command appeared to hang.  This patch adds an
+        explaination of what's going on.  It also adds a confirmation prompt
+        before launching the browser to give the user a chance to read the
+        text.  If that's too much of a speed bump, we can iterate.
+
+        * Scripts/webkitpy/tool/commands/gardenomatic.py:
+
 2011-09-21  Chang Shu  <cshu@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py

@@ -34 +34 @@
 
     def execute(self, options, args, tool):
-        self._tool.user.open_url(self.url)
+        print "This command runs a local HTTP server that changes your working copy"
+        print "based on the actions you take in the web-based UI."
+        if tool.user.confirm("Open the web-based UI before starting the local server?"):
+            self._tool.user.open_url(self.url)
         httpd = GardeningHTTPServer(httpd_port=8127, config={'tool': tool})
+        print "Local HTTP server started."
         httpd.serve_forever()