Changeset 95632 in webkit

Timestamp:

Sep 21, 2011 8:19:16 AM (13 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: make WebInspector a bit more timeline friendly.
​https://bugs.webkit.org/show_bug.cgi?id=68534

I found that the maximum captured stack frame depth tracked by timeline is not
very convenient because the average depth of call stack considerably more than five.
Another useful trick is console.timeStamp for all backend calls.

Reviewed by Yury Semikhatsky.

• inspector/CodeGeneratorInspector.pm:
• inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspector.pm (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-21  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: make WebInspector a bit more timeline friendly.
+        https://bugs.webkit.org/show_bug.cgi?id=68534
+
+        I found that the maximum captured stack frame depth tracked by timeline is not
+        very convenient because the average depth of call stack considerably more than five.
+        Another useful trick is console.timeStamp for all backend calls.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/CodeGeneratorInspector.pm:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
+
 2011-09-21  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
 

trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

@@ -861 +861 @@
     sendMessageObjectToBackend: function(messageObject)
     {
+        console.timeStamp(messageObject.method);
         var message = JSON.stringify(messageObject);
         InspectorFrontendHost.sendMessageToBackend(message);

trunk/Source/WebCore/inspector/front-end/TimelinePanel.js

@@ -348 +348 @@
         else {
             this._clearPanel();
-            WebInspector.timelineManager.start();
+            WebInspector.timelineManager.start(30);
             WebInspector.userMetrics.TimelineStarted.record();
         }