Changeset 95640 in webkit

Timestamp:

Sep 21, 2011 9:39:50 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
​https://bugs.webkit.org/show_bug.cgi?id=68351

Patch by chandra shekar vallala <​chandra.vallala@gmail.com> on 2011-09-21
Reviewed by Darin Fisher.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::clearFocusedNode):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-21  chandra shekar vallala  <chandra.vallala@gmail.com>
+
+        [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element.
+        https://bugs.webkit.org/show_bug.cgi?id=68351
+
+        Reviewed by Darin Fisher.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::clearFocusedNode):
+
 2011-09-20  Jay Civelli  <jcivelli@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -1803 +1803 @@
     // processing keyboard events even though focus has been moved to the page and
     // keystrokes get eaten as a result.
-    if (oldFocusedNode->hasTagName(HTMLNames::textareaTag)
-        || (oldFocusedNode->hasTagName(HTMLNames::inputTag)
-            && static_cast<HTMLInputElement*>(oldFocusedNode.get())->isTextField())) {
+    if (oldFocusedNode->isContentEditable()
+        || (oldFocusedNode->isElementNode()
+            && static_cast<Element*>(oldFocusedNode.get())->isTextFormControl())) {
         frame->selection()->clear();
     }