Changeset 95656 in webkit

Timestamp:

Sep 21, 2011 11:59:29 AM (13 years ago)

Author:

demarchi@webkit.org

Message:

[EFL] Don't try to free user-provided list
​https://bugs.webkit.org/show_bug.cgi?id=68356

Reviewed by Antonio Gomes.

A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
wrong manner. If we intended to free the data, we should call free()
(or whatever function is required to destroy it). However not only did
it use the wrong EFL api but it also introduced a change in behavior,
freeing user-provided data.

• ewk/ewk_frame.cpp:

(ewk_frame_feed_touch_event): do not free user-provided data.

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_frame.cpp (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
+
+        [EFL] Don't try to free user-provided list
+        https://bugs.webkit.org/show_bug.cgi?id=68356
+
+        Reviewed by Antonio Gomes.
+
+        A coding-style cleanup revealed that we were using EINA_LIST_FREE in a
+        wrong manner. If we intended to free the data, we should call free()
+        (or whatever function is required to destroy it). However not only did
+        it use the wrong EFL api but it also introduced a change in behavior,
+        freeing user-provided data.
+
+        * ewk/ewk_frame.cpp:
+        (ewk_frame_feed_touch_event): do not free user-provided data.
+
 2011-09-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_frame.cpp

@@ -932 +932 @@
     EWK_FRAME_SD_GET(o, sd);
 
-    if (!sd || !sd->frame || !ewk_view_need_touch_events_get(sd->view)) {
-        void *point;
-        EINA_LIST_FREE(points, point);
+    if (!sd || !sd->frame || !ewk_view_need_touch_events_get(sd->view))
         return EINA_FALSE;
-    }
 
     Evas_Coord x, y;