Changeset 95710 in webkit

Timestamp:

Sep 22, 2011 5:43:32 AM (13 years ago)

Author:

jesus@webkit.org

Message:

[Qt] Redirection overflow errors have wrong error domain
​https://bugs.webkit.org/show_bug.cgi?id=68612

Reviewed by Andreas Kling.

Source/WebCore:

Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.

• platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::redirect):

Source/WebKit2:

Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().

• UIProcess/API/qt/qweberror.cpp:

(QWebError::type):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/network/qt/QNetworkReplyHandler.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/API/qt/qweberror.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
+
+        [Qt] Redirection overflow errors have wrong error domain
+        https://bugs.webkit.org/show_bug.cgi?id=68612
+
+        Reviewed by Andreas Kling.
+
+        Redirection overflow currently puts the URL hostname in the errorDomain field.
+        Now redirection overflow errors will be classified as "HTTP" errors.
+
+        * platform/network/qt/QNetworkReplyHandler.cpp:
+        (WebCore::QNetworkReplyHandler::redirect):
+
 2011-09-22  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp

@@ -529 +529 @@
     m_redirectionTries--;
     if (!m_redirectionTries) {
-        ResourceError error(newUrl.host(), 400 /*bad request*/,
+        ResourceError error("HTTP", 400 /*bad request*/,
                             newUrl.toString(),
                             QCoreApplication::translate("QWebPage", "Redirection limit reached"));

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-09-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
+
+        [Qt] Redirection overflow errors have wrong error domain
+        https://bugs.webkit.org/show_bug.cgi?id=68612
+
+        Reviewed by Andreas Kling.
+
+        Redirection overflow currently puts the URL hostname in the errorDomain field
+        and therefore are treated as a QWebError::EngineError. From now on they
+        will be treated as QWebError::HttpError, since their error domain was modified
+        to "HTTP" in QNetworkReplyHandler::redirect().
+
+        * UIProcess/API/qt/qweberror.cpp:
+        (QWebError::type):
+
 2011-09-22  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/qt/qweberror.cpp

@@ -68 +68 @@
     if (errorDomain == "Download")
         return QWebError::DownloadError;
-    // FIXME: Redirection overflow currently puts the URL hostname in the errorDomain field.
-    //        We should expose that error somehow. Source is QNetworkReplyHandler::redirect().
     return QWebError::EngineError;
 }