Changeset 95721 in webkit


Ignore:
Timestamp:
Sep 22, 2011 9:14:30 AM (13 years ago)
Author:
robert@webkit.org
Message:

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.

CSS outline property on a narrow element has rabbit ear artifacts
​https://bugs.webkit.org/show_bug.cgi?id=36793

Patch by Jason Liu <​jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <​robert@webkit.org>

Source/WebCore:

Test: fast/css/outline-narrowLine.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

  • fast/css/outline-narrowLine.html: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/qt/fast/css/outline-narrowLine-expected.png: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
  • platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r95718 r95721  
     12011-09-20  Jason Liu  <jason.liu@torchmobile.com.cn>
     2
     3        Reviewed by Simon Fraser.
     4
     5        CSS outline property on a narrow element has rabbit ear artifacts
     6        https://bugs.webkit.org/show_bug.cgi?id=36793
     7
     8        Patch by Jason Liu  <jason.liu@torchmobile.com.cn>
     9        Patch updated by Robert Hogan <robert@webkit.org>
     10
     11        * fast/css/outline-narrowLine.html: Added.
     12        * platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
     13        * platform/qt/fast/css/outline-narrowLine-expected.png: Added.
     14        * platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
     15        * platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.
     16
    1172011-09-22  Marcus Bulach  <bulach@chromium.org>
    218

  • trunk/Source/WebCore/ChangeLog

    r95720 r95721  
     12011-09-20  Jason Liu  <jason.liu@torchmobile.com.cn>
     2
     3        Reviewed by Simon Fraser.
     4
     5        CSS outline property on a narrow element has rabbit ear artifacts
     6        https://bugs.webkit.org/show_bug.cgi?id=36793
     7
     8        Patch by Jason Liu  <jason.liu@torchmobile.com.cn>
     9        Patch updated by Robert Hogan <robert@webkit.org>
     10
     11        Test: fast/css/outline-narrowLine.html
     12
     13        * rendering/RenderInline.cpp:
     14        (WebCore::RenderInline::paintOutlineForLine):
     15
    1162011-09-22  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
    217

  • trunk/Source/WebCore/rendering/RenderInline.cpp

    r94259 r95721  
    14761476            (!lastline.isEmpty() && left - outlineWidth < paintOffset.x() + lastline.maxX()) ? -outlineWidth : outlineWidth,
    14771477            outlineWidth, antialias);
    1478    
     1478
     1479    if (thisline.x() == thisline.maxX())
     1480          drawLineForBoxSide(graphicsContext,
     1481            left - outlineWidth,
     1482            top - outlineWidth,
     1483            right + outlineWidth,
     1484            top,
     1485            BSTop, outlineColor, outlineStyle,
     1486            outlineWidth,
     1487            outlineWidth,
     1488            antialias);
     1489
    14791490    // lower edge
    14801491    if (thisline.x() < nextline.x())
    … …  
    14981509            (!nextline.isEmpty() && left - outlineWidth < paintOffset.x() + nextline.maxX()) ? -outlineWidth : outlineWidth,
    14991510            outlineWidth, antialias);
     1511
     1512    if (thisline.x() == thisline.maxX())
     1513          drawLineForBoxSide(graphicsContext,
     1514            left - outlineWidth,
     1515            bottom,
     1516            right + outlineWidth,
     1517            bottom + outlineWidth,
     1518            BSBottom, outlineColor, outlineStyle,
     1519            outlineWidth,
     1520            outlineWidth,
     1521            antialias);
    15001522}
    15011523
Note: See TracChangeset for help on using the changeset viewer.