Changeset 95732 in webkit


Ignore:
Timestamp:
Sep 22, 2011 10:47:13 AM (13 years ago)
Author:
Adam Roben
Message:

Use the "direct object" form of system() to run WebKit.exe

This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.

Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%

Reviewed by Steve Falkenburg.

  • Scripts/webkitdirs.pm:

(runSafari):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r95731 r95732  
     12011-09-22  Adam Roben  <aroben@apple.com>
     2
     3        Use the "direct object" form of system() to run WebKit.exe
     4
     5        This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
     6        path to WebKit.exe.
     7
     8        Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
     9        %WEBKITOUTPUTDIR%
     10
     11        Reviewed by Steve Falkenburg.
     12
     13        * Scripts/webkitdirs.pm:
     14        (runSafari):
     15
    1162011-09-22  Adam Roben  <aroben@apple.com>
    217
  • trunk/Tools/Scripts/webkitdirs.pm

    r95731 r95732  
    20292029            $result = system $vcBuildPath, "/debugexe", "\"$safariPath\"", @ARGV;
    20302030        } else {
    2031             $result = system File::Spec->catfile(productDir(), "WebKit.exe"), @ARGV;
     2031            my $webKitLauncherPath = File::Spec->catfile(productDir(), "WebKit.exe");
     2032            $result = system { $webKitLauncherPath } $webKitLauncherPath, @ARGV;
    20322033        }
    20332034        return $result if $result;
Note: See TracChangeset for help on using the changeset viewer.