Changeset 95776 in webkit


Ignore:
Timestamp:
Sep 22, 2011 7:41:55 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297

Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.

No functional change, no new test needed.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r95774 r95776  
     12011-09-22  Antoine Labour  <piman@chromium.org>
     2
     3        Remove unused members from LayerChromium.
     4        These members are never set, and never used.
     5        Other members that are set but not used have been left (we may use them
     6        later, e.g. m_opaque).
     7        https://bugs.webkit.org/show_bug.cgi?id=68297
     8
     9        Reviewed by James Robinson.
     10
     11        No functional change, no new test needed.
     12
     13        * platform/graphics/chromium/LayerChromium.cpp:
     14        (WebCore::LayerChromium::LayerChromium):
     15        * platform/graphics/chromium/LayerChromium.h:
     16
    1172011-09-22  Tom Sepez  <tsepez@chromium.org>
    218
  • trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp

    r95406 r95776  
    6565    , m_debugBorderWidth(0)
    6666    , m_opacity(1.0)
    67     , m_zPosition(0.0)
    6867    , m_anchorPointZ(0)
    69     , m_clearsContext(false)
    70     , m_hidden(false)
    7168    , m_masksToBounds(false)
    7269    , m_opaque(true)
    73     , m_geometryFlipped(false)
    74     , m_needsDisplayOnBoundsChange(false)
    7570    , m_doubleSided(true)
    7671    , m_usesLayerScissor(false)
     
    221216    else
    222217        setNeedsCommit();
    223 }
    224 
    225 void LayerChromium::setFrame(const FloatRect& rect)
    226 {
    227     if (rect == m_frame)
    228       return;
    229 
    230     m_frame = rect;
    231     setNeedsDisplay(FloatRect(0, 0, bounds().width(), bounds().height()));
    232218}
    233219
  • trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h

    r95406 r95776  
    9797    virtual IntSize contentBounds() const { return bounds(); }
    9898
    99     void setClearsContext(bool clears) { m_clearsContext = clears; setNeedsCommit(); }
    100     bool clearsContext() const { return m_clearsContext; }
    101 
    102     void setFrame(const FloatRect&);
    103     FloatRect frame() const { return m_frame; }
    104 
    105     void setHidden(bool hidden) { m_hidden = hidden; setNeedsCommit(); }
    106     bool isHidden() const { return m_hidden; }
    107 
    10899    void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; }
    109100    bool masksToBounds() const { return m_masksToBounds; }
     
    120111    void resetNeedsDisplay();
    121112
    122     void setNeedsDisplayOnBoundsChange(bool needsDisplay) { m_needsDisplayOnBoundsChange = needsDisplay; }
    123 
    124113    void setOpacity(float opacity) { m_opacity = opacity; setNeedsCommit(); }
    125114    float opacity() const { return m_opacity; }
     
    131120    FloatPoint position() const { return m_position; }
    132121
    133     void setZPosition(float zPosition) { m_zPosition = zPosition; setNeedsCommit(); }
    134     float zPosition() const {  return m_zPosition; }
    135 
    136122    void setSublayerTransform(const TransformationMatrix& transform) { m_sublayerTransform = transform; setNeedsCommit(); }
    137123    const TransformationMatrix& sublayerTransform() const { return m_sublayerTransform; }
     
    148134    bool doubleSided() const { return m_doubleSided; }
    149135    void setDoubleSided(bool doubleSided) { m_doubleSided = doubleSided; setNeedsCommit(); }
    150 
    151     // FIXME: This setting is currently ignored.
    152     void setGeometryFlipped(bool flipped) { m_geometryFlipped = flipped; setNeedsCommit(); }
    153     bool geometryFlipped() const { return m_geometryFlipped; }
    154136
    155137    bool preserves3D() const { return m_delegate && m_delegate->preserves3D(); }
     
    262244    float m_debugBorderWidth;
    263245    float m_opacity;
    264     float m_zPosition;
    265246    float m_anchorPointZ;
    266     bool m_clearsContext;
    267     bool m_hidden;
    268247    bool m_masksToBounds;
    269248    bool m_opaque;
    270     bool m_geometryFlipped;
    271     bool m_needsDisplayOnBoundsChange;
    272249    bool m_doubleSided;
    273250    bool m_usesLayerScissor;
     
    276253    TransformationMatrix m_transform;
    277254    TransformationMatrix m_sublayerTransform;
    278 
    279     FloatRect m_frame;
    280255
    281256    // Replica layer used for reflections.
Note: See TracChangeset for help on using the changeset viewer.