Changeset 95801 in webkit

Timestamp:

Sep 23, 2011 7:35:07 AM (13 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
​https://bugs.webkit.org/show_bug.cgi?id=68657

Reviewed by Yury Semikhatsky.

• English.lproj/localizedStrings.js:
• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):

• inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

• inspector/front-end/inspector.js:

(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/NetworkPanel.js (modified) (1 diff)
• inspector/front-end/ResourcesPanel.js (modified) (1 diff)
• inspector/front-end/inspector.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-23  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
+        https://bugs.webkit.org/show_bug.cgi?id=68657
+
+        Reviewed by Yury Semikhatsky.
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype.showAnchorLocation):
+        (WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
+        * inspector/front-end/ResourcesPanel.js:
+        (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
+        (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
+        * inspector/front-end/inspector.js:
+        (WebInspector.openInNetworkPanelLabel):
+        (WebInspector.openRequestInNetworkPanel):
+
 2011-09-23  Deepak Sherveghar  <bpwv64@motorola.com>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -1386 +1386 @@
     {
         var resource = this._resourceByAnchor(anchor);
-
+        this.revealAndHighlightResource(resource)
+    },
+
+    revealAndHighlightResource: function(resource)
+    {
         this._toggleGridMode();
         if (resource)

trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js

@@ -1236 +1236 @@
         var contextMenu = new WebInspector.ContextMenu();
         contextMenu.appendItem(WebInspector.openLinkExternallyLabel(), WebInspector.openResource.bind(WebInspector, this._resource.url, false));
+        this._appendOpenInNetworkPanelAction(contextMenu, event);
         this._appendSaveAsAction(contextMenu, event);
         contextMenu.show(event);
+    },
+
+    _appendOpenInNetworkPanelAction: function(contextMenu, event)
+    {
+        if (!this._resource.requestId)
+            return;
+
+        contextMenu.appendItem(WebInspector.openInNetworkPanelLabel(), WebInspector.openRequestInNetworkPanel.bind(WebInspector, this._resource));
     },
 

trunk/Source/WebCore/inspector/front-end/inspector.js

@@ -437 +437 @@
     },
 
+    openInNetworkPanelLabel: function()
+    {
+        return WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Open in network panel" : "Open in Network Panel");
+    },
+
     copyLinkAddressLabel: function()
     {
@@ -718 +723 @@
     } else
         PageAgent.open(resourceURL, true);
+}
+
+WebInspector.openRequestInNetworkPanel = function(resource)
+{
+    WebInspector.showPanel("network");
+    WebInspector.panels.network.revealAndHighlightResource(resource);
 }