Changeset 95960 in webkit


Ignore:
Timestamp:
Sep 26, 2011 10:34:08 AM (13 years ago)
Author:
Simon Fraser
Message:

Groove/inset/outset borders show solid if the color is black.
​https://bugs.webkit.org/show_bug.cgi?id=58608

Patch by Antaryami Pandia <​antaryami.pandia@motorola.com> on 2011-09-26
Reviewed by Simon Fraser.

Source/WebCore:

Lightened the border side colors when drawing borders with styles as
Outset/Inset/Groove/Ridge.

Tests: fast/borders/border-groove.html

fast/borders/border-inset.html
fast/borders/border-outset.html
fast/borders/border-ridge.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-groove-expected.png: Added.
  • fast/borders/border-groove-expected.txt: Added.
  • fast/borders/border-groove.html: Added.
  • fast/borders/border-inset-expected.png: Added.
  • fast/borders/border-inset-expected.txt: Added.
  • fast/borders/border-inset.html: Added.
  • fast/borders/border-outset-expected.png: Added.
  • fast/borders/border-outset-expected.txt: Added.
  • fast/borders/border-outset.html: Added.
  • fast/borders/border-ridge-expected.png: Added.
  • fast/borders/border-ridge-expected.txt: Added.
  • fast/borders/border-ridge.html: Added.
Location:
trunk
Files:
12 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r95959 r95960  
     12011-09-26  Antaryami Pandia  <antaryami.pandia@motorola.com>
     2
     3        Groove/inset/outset borders show solid if the color is black.
     4        https://bugs.webkit.org/show_bug.cgi?id=58608
     5
     6        Reviewed by Simon Fraser.
     7
     8        * fast/borders/border-groove-expected.png: Added.
     9        * fast/borders/border-groove-expected.txt: Added.
     10        * fast/borders/border-groove.html: Added.
     11        * fast/borders/border-inset-expected.png: Added.
     12        * fast/borders/border-inset-expected.txt: Added.
     13        * fast/borders/border-inset.html: Added.
     14        * fast/borders/border-outset-expected.png: Added.
     15        * fast/borders/border-outset-expected.txt: Added.
     16        * fast/borders/border-outset.html: Added.
     17        * fast/borders/border-ridge-expected.png: Added.
     18        * fast/borders/border-ridge-expected.txt: Added.
     19        * fast/borders/border-ridge.html: Added.
     20
    1212011-09-26  Abhishek Arya  <inferno@chromium.org>
    222

  • trunk/Source/WebCore/ChangeLog

    r95959 r95960  
     12011-09-26  Antaryami Pandia  <antaryami.pandia@motorola.com>
     2
     3        Groove/inset/outset borders show solid if the color is black.
     4        https://bugs.webkit.org/show_bug.cgi?id=58608
     5
     6        Reviewed by Simon Fraser.
     7
     8        Lightened the border side colors when drawing borders with styles as
     9        Outset/Inset/Groove/Ridge.
     10
     11        Tests: fast/borders/border-groove.html
     12               fast/borders/border-inset.html
     13               fast/borders/border-outset.html
     14               fast/borders/border-ridge.html
     15
     16        * rendering/RenderObject.cpp:
     17        (WebCore::RenderObject::drawLineForBoxSide):
     18
    1192011-09-26  Abhishek Arya  <inferno@chromium.org>
    220

  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r95926 r95960  
    935935        }
    936936        case INSET:
    937             // FIXME: Maybe we should lighten the colors on one side like Firefox.
    938             // https://bugs.webkit.org/show_bug.cgi?id=58608
    939             if (side == BSTop || side == BSLeft)
    940                 color = color.dark();
    941937            // fall through
    942938        case OUTSET:
    943             if (style == OUTSET && (side == BSBottom || side == BSRight))
    944                 color = color.dark();
     939            if (style == INSET) {
     940                if (side == BSTop || side == BSLeft)
     941                    color = color.dark();
     942                else if (side == BSBottom || side == BSRight)
     943                    color = color.light();
     944            } else if (style == OUTSET) {
     945                if (side == BSTop || side == BSLeft)
     946                    color = color.light();
     947                else if (side == BSBottom || side == BSRight)
     948                    color = color.dark();
     949            }
    945950            // fall through
    946951        case SOLID: {
Note: See TracChangeset for help on using the changeset viewer.