Changeset 95974 in webkit


Ignore:
Timestamp:
Sep 26, 2011 12:43:56 PM (13 years ago)
Author:
mihaip@chromium.org
Message:

Unreviewed, rolling out r95960.
​http://trac.webkit.org/changeset/95960
​https://bugs.webkit.org/show_bug.cgi?id=58608

Significantly changes table border rendering

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

LayoutTests:

  • fast/borders/border-groove-expected.png: Removed.
  • fast/borders/border-groove-expected.txt: Removed.
  • fast/borders/border-groove.html: Removed.
  • fast/borders/border-inset-expected.png: Removed.
  • fast/borders/border-inset-expected.txt: Removed.
  • fast/borders/border-inset.html: Removed.
  • fast/borders/border-outset-expected.png: Removed.
  • fast/borders/border-outset-expected.txt: Removed.
  • fast/borders/border-outset.html: Removed.
  • fast/borders/border-ridge-expected.png: Removed.
  • fast/borders/border-ridge-expected.txt: Removed.
  • fast/borders/border-ridge.html: Removed.
Location:
trunk
Files:
12 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r95969 r95974  
     12011-09-26  Mihai Parparita  <mihaip@chromium.org>
     2
     3        Unreviewed, rolling out r95960.
     4        http://trac.webkit.org/changeset/95960
     5        https://bugs.webkit.org/show_bug.cgi?id=58608
     6
     7        Significantly changes table border rendering
     8
     9        * fast/borders/border-groove-expected.png: Removed.
     10        * fast/borders/border-groove-expected.txt: Removed.
     11        * fast/borders/border-groove.html: Removed.
     12        * fast/borders/border-inset-expected.png: Removed.
     13        * fast/borders/border-inset-expected.txt: Removed.
     14        * fast/borders/border-inset.html: Removed.
     15        * fast/borders/border-outset-expected.png: Removed.
     16        * fast/borders/border-outset-expected.txt: Removed.
     17        * fast/borders/border-outset.html: Removed.
     18        * fast/borders/border-ridge-expected.png: Removed.
     19        * fast/borders/border-ridge-expected.txt: Removed.
     20        * fast/borders/border-ridge.html: Removed.
     21
    1222011-09-26  Mihai Parparita  <mihaip@chromium.org>
    223

  • trunk/Source/WebCore/ChangeLog

    r95967 r95974  
     12011-09-26  Mihai Parparita  <mihaip@chromium.org>
     2
     3        Unreviewed, rolling out r95960.
     4        http://trac.webkit.org/changeset/95960
     5        https://bugs.webkit.org/show_bug.cgi?id=58608
     6
     7        Significantly changes table border rendering
     8
     9        * rendering/RenderObject.cpp:
     10        (WebCore::RenderObject::drawLineForBoxSide):
     11
    1122011-09-23  Simon Fraser  <simon.fraser@apple.com>
    213

  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r95960 r95974  
    935935        }
    936936        case INSET:
     937            // FIXME: Maybe we should lighten the colors on one side like Firefox.
     938            // https://bugs.webkit.org/show_bug.cgi?id=58608
     939            if (side == BSTop || side == BSLeft)
     940                color = color.dark();
    937941            // fall through
    938942        case OUTSET:
    939             if (style == INSET) {
    940                 if (side == BSTop || side == BSLeft)
    941                     color = color.dark();
    942                 else if (side == BSBottom || side == BSRight)
    943                     color = color.light();
    944             } else if (style == OUTSET) {
    945                 if (side == BSTop || side == BSLeft)
    946                     color = color.light();
    947                 else if (side == BSBottom || side == BSRight)
    948                     color = color.dark();
    949             }
     943            if (style == OUTSET && (side == BSBottom || side == BSRight))
     944                color = color.dark();
    950945            // fall through
    951946        case SOLID: {
Note: See TracChangeset for help on using the changeset viewer.