Changeset 95978 in webkit

Timestamp:

Sep 26, 2011 12:51:15 PM (13 years ago)

Author:

jer.noble@apple.com

Message:

White flash when entering full-screen using element.webkitRequestFullScreen()
​https://bugs.webkit.org/show_bug.cgi?id=68481

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; covered by existing full screen tests.

During an animation, renderers may try to paint into the FullScreenRenderer's
GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's
background will cause these paints to fail. Remove this optimization in
containsPaintedContent, and taking non-composited elements into full screen will
animate correctly.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::containsPaintedContent):

Source/WebKit2:

Do not re-enable screen updates after exiting compositing mode until a repaint has completed.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
(continueExitCompositingModeAfterRepaintCallback):
(-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-26  Jer Noble  <jer.noble@apple.com>
+
+        White flash when entering full-screen using element.webkitRequestFullScreen()
+        https://bugs.webkit.org/show_bug.cgi?id=68481
+
+        Reviewed by Simon Fraser.
+
+        No new tests; covered by existing full screen tests.
+
+        During an animation, renderers may try to paint into the FullScreenRenderer's 
+        GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's 
+        background will cause these paints to fail. Remove this optimization in 
+        containsPaintedContent, and taking non-composited elements into full screen will
+        animate correctly.
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::containsPaintedContent):
+
 2011-09-26  Mihai Parparita  <mihaip@chromium.org>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -911 +911 @@
         return hasBoxDecorationsOrBackground(renderer());
 #endif
-#if ENABLE(FULLSCREEN_API)
-    if (renderer()->isRenderFullScreen())
-        return false;
-#endif
 
     return true;

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-09-26  Jer Noble  <jer.noble@apple.com>
+
+        White flash when entering full-screen using element.webkitRequestFullScreen()
+        https://bugs.webkit.org/show_bug.cgi?id=68481
+
+        Reviewed by Simon Fraser.
+
+        Do not re-enable screen updates after exiting compositing mode until a repaint has completed.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
+        (continueExitCompositingModeAfterRepaintCallback):
+        (-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]):
+
 2011-09-23  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

@@ -76 +76 @@
 @end
 
+static void continueExitCompositingModeAfterRepaintCallback(WKErrorRef error, void* context);
+
 @interface WKFullScreenWindowController(Private)
 - (void)_requestExitFullScreenWithAnimation:(BOOL)animation;
@@ -85 +87 @@
 - (WebPageProxy*)_page;
 - (WebFullScreenManagerProxy*)_manager;
+- (void)_continueExitCompositingModeAfterRepaint;
 @end
 
@@ -413 +416 @@
     
     _layerHostingView = 0;
+    [self _page]->forceRepaint(VoidCallback::create(self, continueExitCompositingModeAfterRepaintCallback));
+}
+
+static void continueExitCompositingModeAfterRepaintCallback(WKErrorRef error, void* context)
+{
+    [(WKFullScreenWindowController*)context _continueExitCompositingModeAfterRepaint];
+}
+
+- (void)_continueExitCompositingModeAfterRepaint
+{
     NSEnableScreenUpdates();