Changeset 96052 in webkit

Timestamp:

Sep 26, 2011 5:36:19 PM (13 years ago)

Author:

timothy_horton@apple.com

Message:

<animateColor> applied to filtered ellipse does not update
​https://bugs.webkit.org/show_bug.cgi?id=68457
<rdar://problem/10154777>

Reviewed by Darin Adler.

Invalidate the filter's cache when style changes take place so that style changes are respected.

Test: svg/filters/animate-fill.svg

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/filters/animate-fill-expected.png (added)
• LayoutTests/svg/filters/animate-fill-expected.txt (added)
• LayoutTests/svg/filters/animate-fill.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/SVGResourcesCache.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-26  Tim Horton  <timothy_horton@apple.com>
+
+        <animateColor> applied to filtered ellipse does not update
+        https://bugs.webkit.org/show_bug.cgi?id=68457
+        <rdar://problem/10154777>
+
+        Reviewed by Darin Adler.
+
+        Test that changing the fill on a filtered shape properly invalidates the filtered result.
+
+        * svg/filters/animate-fill-expected.png: Added.
+        * svg/filters/animate-fill-expected.txt: Added.
+        * svg/filters/animate-fill.svg: Added.
+
 2011-09-26  Mihai Parparita  <mihaip@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-26  Tim Horton  <timothy_horton@apple.com>
+
+        <animateColor> applied to filtered ellipse does not update
+        https://bugs.webkit.org/show_bug.cgi?id=68457
+        <rdar://problem/10154777>
+
+        Reviewed by Darin Adler.
+
+        Invalidate the filter's cache when style changes take place so that style changes are respected.
+
+        Test: svg/filters/animate-fill.svg
+
+        * rendering/svg/SVGResourcesCache.cpp:
+        (WebCore::SVGResourcesCache::clientStyleChanged):
+        (WebCore::SVGResourcesCache::clientUpdatedFromElement):
+
 2011-09-26  Max Perepelitsyn  <pph34r@gmail.com>
 

trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp

@@ -129 +129 @@
         return;
 
-    // In this case the proper SVGFE*Element will imply whether the modifided CSS properties implies a relayout or repaint.
+    // In this case the proper SVGFE*Element will decide whether the modified CSS properties require a relayout or repaint.
     if (renderer->isSVGResourceFilterPrimitive() && diff == StyleDifferenceRepaint)
         return;
@@ -145 +145 @@
     cache->removeResourcesFromRenderObject(renderer);
     cache->addResourcesFromRenderObject(renderer, newStyle);
+
+    SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(renderer);
+    if (!resources)
+        return;
+
+    resources->removeClientFromCache(renderer);
 }