Changeset 96100 in webkit

Timestamp:

Sep 27, 2011 5:39:16 AM (13 years ago)

Author:

yurys@chromium.org

Message:

[Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
​https://bugs.webkit.org/show_bug.cgi?id=67732

Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.

Reviewed by Pavel Feldman.

• src/js/Tests.js:

(.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
(.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
(.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
(.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
(.TestSuite.prototype.testConsoleOnNavigateBack):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/js/Tests.js (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-27  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: Bug with console.log and popstate/hashchange events
+        https://bugs.webkit.org/show_bug.cgi?id=67732
+
+        Added WebKit part of a new interactive UI test for the bug with duplicated console messages after navigation back.
+
+        Reviewed by Pavel Feldman.
+
+        * src/js/Tests.js:
+        (.TestSuite.prototype.testConsoleOnNavigateBack.firstConsoleMessageReceived):
+        (.TestSuite.prototype.testConsoleOnNavigateBack.didClickLink):
+        (.TestSuite.prototype.testConsoleOnNavigateBack.didNavigateBack):
+        (.TestSuite.prototype.testConsoleOnNavigateBack.didCompleteNavigation):
+        (.TestSuite.prototype.testConsoleOnNavigateBack):
+
 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/chromium/src/js/Tests.js

@@ -537 +537 @@
 
 
+TestSuite.prototype.testConsoleOnNavigateBack = function()
+{
+    if (WebInspector.console.messages.length === 1)
+        firstConsoleMessageReceived.call(this);
+    else
+        WebInspector.console.addEventListener(WebInspector.ConsoleModel.Events.MessageAdded, firstConsoleMessageReceived, this);
+
+    function firstConsoleMessageReceived() {
+        this.evaluateInConsole_("clickLink();", didClickLink.bind(this));
+    }
+
+    function didClickLink() {
+        // Check that there are no new messages(command is not a message).
+        this.assertEquals(1, WebInspector.console.messages.length);
+        this.assertEquals(1, WebInspector.console.messages[0].totalRepeatCount);
+        this.evaluateInConsole_("history.back();", didNavigateBack.bind(this));
+    }
+
+    function didNavigateBack()
+    {
+        // Make sure navigation completed and possible console messages were pushed.
+        this.evaluateInConsole_("void 0;", didCompleteNavigation.bind(this));
+    }
+
+    function didCompleteNavigation() {
+        this.assertEquals(1, WebInspector.console.messages.length);
+        this.assertEquals(1, WebInspector.console.messages[0].totalRepeatCount);
+        this.releaseControl();
+    }
+
+    this.takeControl();
+};
+
+
 TestSuite.prototype.testSharedWorker = function()
 {