Changeset 96127 in webkit

Timestamp:

Sep 27, 2011 10:29:46 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

AXObjectCache cleared unnecessarily when non-top Document is detached.
​https://bugs.webkit.org/show_bug.cgi?id=68636

Patch by Dominic Mazzoni <​dmazzoni@google.com> on 2011-09-27
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/deleting-iframe-destroys-axcache.html

• dom/Document.cpp:

(WebCore::Document::attach):
(WebCore::Document::detach):

LayoutTests:

• accessibility/deleting-iframe-destroys-axcache.html: Added.
• platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/deleting-iframe-destroys-axcache.html (added)
• LayoutTests/platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-27  Dominic Mazzoni  <dmazzoni@google.com>
+
+        AXObjectCache cleared unnecessarily when non-top Document is detached.
+        https://bugs.webkit.org/show_bug.cgi?id=68636
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/deleting-iframe-destroys-axcache.html: Added.
+        * platform/mac/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
+
 2011-09-26  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-27  Dominic Mazzoni  <dmazzoni@google.com>
+
+        AXObjectCache cleared unnecessarily when non-top Document is detached.
+        https://bugs.webkit.org/show_bug.cgi?id=68636
+
+        Reviewed by Chris Fleizach.
+
+        Test: accessibility/deleting-iframe-destroys-axcache.html
+
+        * dom/Document.cpp:
+        (WebCore::Document::attach):
+        (WebCore::Document::detach):
+
 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1802 +1802 @@
     ASSERT(!attached());
     ASSERT(!m_inPageCache);
-    ASSERT(!m_axObjectCache);
+    ASSERT(!m_axObjectCache || this != topDocument());
 
     if (!m_renderArena)
@@ -1828 +1828 @@
     ASSERT(!m_inPageCache);
 
-    clearAXObjectCache();
+    if (this == topDocument())
+        clearAXObjectCache();
+
     stopActiveDOMObjects();
     m_eventQueue->close();