Changeset 96166 in webkit

Timestamp:

Sep 27, 2011 4:05:01 PM (13 years ago)

Author:

tkent@chromium.org

Message:

[V8] element.dataset.nonExistingKey should return undefined.
​https://bugs.webkit.org/show_bug.cgi?id=68877

Reviewed by Nate Chapin.

Source/WebCore:

• bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().

LayoutTests:

• fast/dom/dataset-expected.txt: Updated.
• fast/dom/script-tests/dataset.js: Add a test case.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/dataset-expected.txt (modified) (1 diff)
• LayoutTests/fast/dom/script-tests/dataset.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-27  Kent Tamura  <tkent@chromium.org>
+
+        [V8] element.dataset.nonExistingKey should return undefined.
+        https://bugs.webkit.org/show_bug.cgi?id=68877
+
+        Reviewed by Nate Chapin.
+
+        * fast/dom/dataset-expected.txt: Updated.
+        * fast/dom/script-tests/dataset.js: Add a test case.
+
 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
 

trunk/LayoutTests/fast/dom/dataset-expected.txt

@@ -16 +16 @@
 PASS testGet('data-', '') is true
 PASS testGet('data-à', 'à') is true
+PASS document.body.dataset.nonExisting is undefined.
 
 PASS matchesNothingInDataset('dataFoo') is true

trunk/LayoutTests/fast/dom/script-tests/dataset.js

@@ -20 +20 @@
 shouldBeTrue("testGet('data-', '')");
 shouldBeTrue("testGet('data-\xE0', '\xE0')");
+shouldBeUndefined("document.body.dataset.nonExisting");
 debug("");
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-27  Kent Tamura  <tkent@chromium.org>
+
+        [V8] element.dataset.nonExistingKey should return undefined.
+        https://bugs.webkit.org/show_bug.cgi?id=68877
+
+        Reviewed by Nate Chapin.
+
+        * bindings/v8/custom/V8DOMStringMapCustom.cpp:
+        (WebCore::V8DOMStringMap::namedPropertyGetter): Uses v8StringOrUndefined() instead of v8String().
+
 2011-09-23  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp

@@ -50 +50 @@
 {
     INC_STATS("DOM.DOMStringMap.NamedPropertyGetter");
-    return v8String(V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name)));
+    return v8StringOrUndefined(V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name)));
 }