Changeset 96174 in webkit


Ignore:
Timestamp:
Sep 27, 2011 6:01:59 PM (13 years ago)
Author:
tony@chromium.org
Message:

http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
​https://bugs.webkit.org/show_bug.cgi?id=34222

Reviewed by Ryosuke Niwa.

Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).

  • http/tests/multipart/stop-crash-expected.txt:
  • http/tests/multipart/stop-crash.html:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r96167 r96174  
     12011-09-27  Tony Chang  <tony@chromium.org>
     2
     3        http/tests/navigation/anchor-basic.html is flaky on Snow Leopard Release Bot
     4        https://bugs.webkit.org/show_bug.cgi?id=34222
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without it, the img onload handler
     9        doesn't always run. Also reduce the multipart timeout (should help to unblock other http requests).
     10
     11        * http/tests/multipart/stop-crash-expected.txt:
     12        * http/tests/multipart/stop-crash.html:
     13
    1142011-09-27  Mihai Parparita  <mihaip@chromium.org>
    215

  • trunk/LayoutTests/http/tests/multipart/stop-crash-expected.txt

    r21536 r96174  
    44
    55
     6PASS

  • trunk/LayoutTests/http/tests/multipart/stop-crash.html

    r21536 r96174  
    22<head>
    33    <script>
    4         if (window.layoutTestController)
     4        if (window.layoutTestController) {
    55            layoutTestController.dumpAsText();
     6            layoutTestController.waitUntilDone();
     7        }
    68
    79        function firstPartLoaded()
    810        {
    911            window.stop();
     12            document.getElementById("results").innerHTML = "PASS";
     13            if (window.layoutTestController)
     14                layoutTestController.notifyDone();
    1015        }
    1116    </script>
    … …  
    1924        If WebKit does not assert or crash after the test, then it passed.
    2025    </p>
    21     <img width=24 height=24 src="resources/multipart.php?interval=0&img1=2x2-green.png&img2=2x2-green.png&wait=10" onload="firstPartLoaded()">
     26    <img width=24 height=24 src="resources/multipart.php?interval=0&img1=2x2-green.png&img2=2x2-green.png&wait=3" onload="firstPartLoaded()">
     27    <p id="results"></p>
    2228</body>
    2329</html>
Note: See TracChangeset for help on using the changeset viewer.