Changeset 96183 in webkit


Ignore:
Timestamp:
Sep 27, 2011 8:37:23 PM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic should load faster and inform the user what is happening
https://bugs.webkit.org/show_bug.cgi?id=68954

Reviewed by Dimitri Glazkov.

This test disables the expected failures tab. The web inspector showed
that loading the data for this tab was slowing down the loading time
for the whole app. We need to find a way to load that data lazily.

This patch also improves the update message to better describe the
progress the app is making analyzing data from the buildbot.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js

    r96153 r96183  
    3939{
    4040    // FIXME: This should be a button with a progress element.
    41     var updating = new ui.notifications.Info('Updating ...');
     41    var numberOfTestsAnalyzed = 0;
     42    var updating = new ui.notifications.Info('Loading commit data ...');
    4243
    4344    g_info.add(updating);
     
    4647
    4748    base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() {
    48         model.analyzeUnexpectedFailures(g_unexpectedFailuresController.update.bind(g_unexpectedFailuresController), function() {
     49        updating.update('Analyzing test failures ...');
     50
     51        model.analyzeUnexpectedFailures(function(failureAnalysis) {
     52            updating.update('Analyzing test failures ... ' + ++numberOfTestsAnalyzed + ' tests analyzed.');
     53            g_unexpectedFailuresController.update(failureAnalysis);
     54        }, function() {
    4955            g_unexpectedFailuresController.purge();
    5056            updating.dismiss();
    5157        });
    52 
    53         model.analyzeExpectedOrUnexpectedFailures(g_failuresController.update.bind(g_failuresController));
    5458    });
    5559}
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

    r96055 r96183  
    7474        ]
    7575        this._tabs = $(this).tabs({
    76             disabled: [1, 2],
     76            disabled: [1, 2, 3],
    7777        });
    7878    },
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

    r96074 r96183  
    8181    init: function(message)
    8282    {
     83        this.update(message);
     84    },
     85    update: function(message)
     86    {
    8387        this._what.textContent = message;
    8488    }
  • trunk/Tools/ChangeLog

    r96181 r96183  
     12011-09-27  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic should load faster and inform the user what is happening
     4        https://bugs.webkit.org/show_bug.cgi?id=68954
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        This test disables the expected failures tab.  The web inspector showed
     9        that loading the data for this tab was slowing down the loading time
     10        for the whole app.  We need to find a way to load that data lazily.
     11
     12        This patch also improves the update message to better describe the
     13        progress the app is making analyzing data from the buildbot.
     14
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
     17        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
     18
    1192011-09-27  Adam Barth  <abarth@webkit.org>
    220
Note: See TracChangeset for help on using the changeset viewer.