Changeset 96185 in webkit

Timestamp:

Sep 27, 2011 9:03:24 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
​https://bugs.webkit.org/show_bug.cgi?id=68967

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-27
Reviewed by Kenneth Russell.

When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
opposed to only a redraw).

Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.

• platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/cc/CCThreadProxy.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-27  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Only initiate the beginFrameAndCommit sequence if a commit has been requested
+        https://bugs.webkit.org/show_bug.cgi?id=68967
+
+        Reviewed by Kenneth Russell.
+
+        When updating the scheduler state, we should only initiate a new commit flow if a commit has been requested (as
+        opposed to only a redraw).
+
+        Covered by the unit test CCLayerTreeHostTestSetNeedsRedraw with USE(THREADED_COMPOSITING) set to true.
+
+        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+        (WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):
+
 2011-09-27  Kentaro Hara  <haraken@chromium.com>
 

trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp

@@ -398 +398 @@
     // commit request into an actual createBeginFrameAndCommitTaskOnCCThread call.
     m_redrawRequestedOnCCThread |= redrawRequested;
-    if (!m_beginFrameAndCommitPendingOnCCThread) {
+    if (commitRequested && !m_beginFrameAndCommitPendingOnCCThread) {
         CCMainThread::postTask(createBeginFrameAndCommitTaskOnCCThread());
         return;