Changeset 96203 in webkit

Timestamp:

Sep 28, 2011 1:06:48 AM (13 years ago)

Author:

timothy_horton@apple.com

Message:

Fix potential SVG performance regression (over-invalidation of caches) from 96052
​https://bugs.webkit.org/show_bug.cgi?id=68941
<rdar://problem/10196224>

Reviewed by Zoltan Herczeg.

Only invalidate the cache of a filter when target style changes, as of the different types of cached
resources, only filters make use of the style of the target element and thus need to be invalidated
when the target style changes.

No new tests, performance improvement.

• rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientUpdatedFromElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/svg/SVGResourcesCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-28  Tim Horton  <timothy_horton@apple.com>
+
+        Fix potential SVG performance regression (over-invalidation of caches) from 96052
+        https://bugs.webkit.org/show_bug.cgi?id=68941
+        <rdar://problem/10196224>
+
+        Reviewed by Zoltan Herczeg.
+
+        Only invalidate the cache of a filter when target style changes, as of the different types of cached
+        resources, only filters make use of the style of the target element and thus need to be invalidated
+        when the target style changes.
+
+        No new tests, performance improvement.
+
+        * rendering/svg/SVGResourcesCache.cpp:
+        (WebCore::SVGResourcesCache::clientUpdatedFromElement):
+
 2011-09-28  Adenilson Cavalcanti  <adenilson.silva@openbossa.org>
 

trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp

@@ -147 +147 @@
 
     SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(renderer);
-    if (!resources)
-        return;
-
-    resources->removeClientFromCache(renderer);
+    if (resources && resources->filter())
+        resources->removeClientFromCache(renderer);
 }