Changeset 96212 in webkit


Ignore:
Timestamp:
Sep 28, 2011 2:54:22 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Implement a PopStateEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=68896

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/pop-state-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
  • dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r96210 r96212  
     12011-09-28  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement a PopStateEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=68896
     5
     6        Reviewed by Adam Barth.
     7
     8        Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-09-28  Ilya Tikhonovsky  <loislo@chromium.org>
    213
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r96208 r96212  
    8181// CSS3 Selectors3 test suite
    8282BUGCR89468 : css3/selectors3 = PASS FAIL
    83 
    84 // This will soon be fixed after implementing a PopStateEvent constructor for V8.
    85 BUGWK67977 : fast/events/constructors/pop-state-event-constructor.html = FAIL
    8683
    8784// Tests for WebVTT parser for <track>.  Feature is not yet functional.
  • trunk/Source/WebCore/ChangeLog

    r96211 r96212  
     12011-09-28  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement a PopStateEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=68896
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/events/constructors/pop-state-event-constructor.html
     9
     10        * bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
     11        * dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
     12
    1132011-09-28  No'am Rosenthal  <noam.rosenthal@nokia.com>
    214
  • trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

    r96208 r96212  
    4040#include "Node.h"
    4141#include "PageTransitionEvent.h"
     42#include "PopStateEvent.h"
    4243#include "ProgressEvent.h"
    4344#include "WebKitAnimationEvent.h"
     
    5455#include "V8Node.h"
    5556#include "V8PageTransitionEvent.h"
     57#include "V8PopStateEvent.h"
    5658#include "V8ProgressEvent.h"
    5759#include "V8Proxy.h"
     
    118120INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    119121INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
     122INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    120123
    121124
  • trunk/Source/WebCore/dom/PopStateEvent.idl

    r96073 r96212  
    3030    interface [
    3131        CanBeConstructed,
    32         CustomConstructFunction
     32        CustomConstructFunction,
     33        V8CustomConstructor
    3334    ] PopStateEvent : Event {
    3435        void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
Note: See TracChangeset for help on using the changeset viewer.