Changeset 96222 in webkit

Timestamp:

Sep 28, 2011 7:30:54 AM (13 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
​https://bugs.webkit.org/show_bug.cgi?id=69002

Reviewed by Yury Semikhatsky.

• inspector/CodeGeneratorInspector.pm:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/CodeGeneratorInspector.pm (modified) (5 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-28  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: It'd be useful to have performance stats for the back-end to front-end communication channel.
+        https://bugs.webkit.org/show_bug.cgi?id=69002
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/CodeGeneratorInspector.pm:
+
 2011-09-27  Pavel Podivilov  <podivilov@chromium.org>
 

trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

@@ -777 +777 @@
 
 InspectorBackendStub.prototype = {
+    dumpInspectorTimeStats: 0,
+    dumpInspectorProtocolMessages: 0,
+
     _wrap: function(callback)
     {
@@ -850 +853 @@
     _wrapCallbackAndSendMessageObject: function(messageObject, callback)
     {
-        messageObject.id = this._wrap(callback || function() {});
-
-        if (window.dumpInspectorProtocolMessages)
+        messageObject.id = this._wrap(callback);
+
+        if (this.dumpInspectorTimeStats) {
+            var wrappedCallback = this._callbacks[messageObject.id];
+            wrappedCallback.methodName = messageObject.method;
+            wrappedCallback.sendRequestTime = Date.now();
+        }
+
+        if (this.dumpInspectorProtocolMessages)
             console.log("frontend: " + JSON.stringify(messageObject));
 
@@ -873 +882 @@
     dispatch: function(message)
     {
-        if (window.dumpInspectorProtocolMessages)
+        if (this.dumpInspectorProtocolMessages)
             console.log("backend: " + ((typeof message === "string") ? message : JSON.stringify(message)));
 
@@ -917 +926 @@
             var callback = this._callbacks[messageObject.id];
             if (callback) {
+                var processingStartTime;
+                if (this.dumpInspectorTimeStats && callback.methodName)
+                    processingStartTime = Date.now();
+
                 arguments.unshift(messageObject.error);
                 callback.apply(null, arguments);
                 --this._pendingResponsesCount;
                 delete this._callbacks[messageObject.id];
+
+                if (this.dumpInspectorTimeStats && callback.methodName)
+                    console.log("time-stats: " + callback.methodName + " = " + (processingStartTime - callback.sendRequestTime) + " + " + (Date.now() - processingStartTime));
             }
 
@@ -953 +969 @@
             }
 
+            var processingStartTime;
+            if (this.dumpInspectorTimeStats)
+                processingStartTime = Date.now();
+
             dispatcher[functionName].apply(dispatcher, params);
+
+            if (this.dumpInspectorTimeStats)
+                console.log("time-stats: " + messageObject.method + " = " + (Date.now() - processingStartTime));
         }
     },