Changeset 96281 in webkit


Ignore:
Timestamp:
Sep 28, 2011 6:01:13 PM (13 years ago)
Author:
macpherson@chromium.org
Message:

Only resolve direction aware properties when properties are direction aware.
https://bugs.webkit.org/show_bug.cgi?id=68968

Reviewed by Eric Seidel.

No new tests / no functionality changed.

Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r96278 r96281  
     12011-09-28  Luke Macpherson   <macpherson@chromium.org>
     2
     3        Only resolve direction aware properties when properties are direction aware.
     4        https://bugs.webkit.org/show_bug.cgi?id=68968
     5
     6        Reviewed by Eric Seidel.
     7
     8        No new tests / no functionality changed.
     9
     10        Profiling showed a ~8% improvement in applyProperty by not calling resolveDirectionAwareProperty for every property.
     11
     12        * css/CSSStyleSelector.cpp:
     13        (WebCore::CSSStyleSelector::applyProperty):
     14
    1152011-09-28  Simon Fraser  <simon.fraser@apple.com>
    216
  • trunk/Source/WebCore/css/CSSStyleSelector.cpp

    r96192 r96281  
    23562356    bool isInitial = valueType == CSSValue::CSS_INITIAL || (!m_parentNode && valueType == CSSValue::CSS_INHERIT);
    23572357
    2358     id = CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode());
    2359 
    23602358    if (m_checker.isMatchingVisitedPseudoClass() && !isValidVisitedLinkProperty(id)) {
    23612359        // Limit the properties that can be applied to only the ones honored by :visited.
     
    36333631    case CSSPropertyWebkitMaxLogicalWidth:
    36343632    case CSSPropertyWebkitMaxLogicalHeight:
    3635         ASSERT_NOT_REACHED();
    3636         break;
    3637 
     3633    {
     3634        int newId = CSSProperty::resolveDirectionAwareProperty(id, m_style->direction(), m_style->writingMode());
     3635        ASSERT(newId != id);
     3636        return applyProperty(newId, value);
     3637    }
    36383638    case CSSPropertyFontStretch:
    36393639    case CSSPropertyPage:
Note: See TracChangeset for help on using the changeset viewer.