Changeset 96349 in webkit

Timestamp:

Sep 29, 2011 12:46:01 PM (13 years ago)

Author:

Nate Chapin

Message:

[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().

​https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

• bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::namedItemAdded):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8DOMWindowShell.cpp (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-29  Nate Chapin  <japhet@chromium.org>
+
+        [V8, chromium] More logging to determine cause of a null
+        v8::Context in V8DOMWindowShell::namedItemAdded().
+
+        https://bugs.webkit.org/show_bug.cgi?id=68099
+
+        Reviewed by Adam Barth.
+
+        * bindings/v8/V8DOMWindowShell.cpp:
+        (WebCore::V8DOMWindowShell::namedItemAdded):
+
 2011-09-29  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

@@ -78 +78 @@
 
 namespace WebCore {
+
+// FIXME: Temporary diagnostics as to why V8 sometimes crashes with a null context in namedItemAdded().
+// See https://bugs.webkit.org/show_bug.cgi?id=68099.
+static int s_contextFailureReason = -1;
 
 static void handleFatalErrorInV8()
@@ -319 +323 @@
         if (m_global.IsEmpty()) {
             disposeContextHandles();
+            s_contextFailureReason = 3;
             return false;
         }
@@ -354 +359 @@
 
     // The activeDocumentLoader pointer could be 0 during frame shutdown.
-    if (!m_frame->loader()->activeDocumentLoader())
+    if (!m_frame->loader()->activeDocumentLoader()) {
+        s_contextFailureReason = 0;
         return result;
+    }
 
     // Create a new environment using an empty template for the shadow
     // object. Reuse the global object if one has been created earlier.
     v8::Persistent<v8::ObjectTemplate> globalTemplate = V8DOMWindow::GetShadowObjectTemplate();
-    if (globalTemplate.IsEmpty())
+    if (globalTemplate.IsEmpty()) {
+        s_contextFailureReason = 1;
         return result;
+    }
 
     // Used to avoid sleep calls in unload handlers.
@@ -388 +397 @@
     result = v8::Context::New(&extensionConfiguration, globalTemplate, global);
 
+    if (result.IsEmpty())
+        s_contextFailureReason = 2;
     return result;
 }
@@ -407 +418 @@
     v8::Local<v8::Object> jsWindow = SafeAllocation::newInstance(windowConstructor);
     // Bail out if allocation failed.
-    if (jsWindow.IsEmpty())
-        return false;
+    if (jsWindow.IsEmpty()) {
+        s_contextFailureReason = 7;
+        return false;
+    }
 
     // Wrap the window.
@@ -574 +587 @@
         // FIXME: Temporary diagnostics as to why V8 sometimes crashes with a null context below.
         // See https://bugs.webkit.org/show_bug.cgi?id=68099.
-        PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.initContextFailed");
+        PlatformSupport::histogramEnumeration("V8Bindings.nullContextState", 0, 3);
         if (m_frame->settings() && !m_frame->settings()->isJavaScriptEnabled())
-            PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.scriptBlockedByWebCoreSettings");
+            PlatformSupport::histogramEnumeration("V8Bindings.nullContextState", 1, 3);
 
         if (!m_frame->script()->canExecuteScripts(NotAboutToExecuteScript))
-            PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.scriptBlockedByScriptController");
-
-        if (V8Proxy::handleOutOfMemory())
-            PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.outOfMemory");
+            PlatformSupport::histogramEnumeration("V8Bindings.nullContextState", 2, 3);
+
+         if (s_contextFailureReason >= 0 && s_contextFailureReason <= 7);
+            PlatformSupport::histogramEnumeration("V8Bindings.nullContextReason", s_contextFailureReason, 8);
+         s_contextFailureReason = -1;
 #endif
         return;
@@ -616 +630 @@
     v8::Handle<v8::String> hiddenObjectPrototypeString = V8HiddenPropertyName::objectPrototype();
     // Bail out if allocation failed.
-    if (objectString.IsEmpty() || prototypeString.IsEmpty() || hiddenObjectPrototypeString.IsEmpty())
-        return false;
+    if (objectString.IsEmpty() || prototypeString.IsEmpty() || hiddenObjectPrototypeString.IsEmpty()) {
+        s_contextFailureReason = 4;
+        return false;
+    }
 
     v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(context->Global()->Get(objectString));
     // Bail out if fetching failed.
-    if (object.IsEmpty())
-        return false;
+    if (object.IsEmpty()) {
+        s_contextFailureReason = 5;
+        return false;
+    }
     v8::Handle<v8::Value> objectPrototype = object->Get(prototypeString);
     // Bail out if fetching failed.
-    if (objectPrototype.IsEmpty())
-        return false;
+    if (objectPrototype.IsEmpty()) {
+        s_contextFailureReason = 6;
+        return false;
+    }
 
     context->Global()->SetHiddenValue(hiddenObjectPrototypeString, objectPrototype);