Changeset 96389 in webkit


Ignore:
Timestamp:
Sep 29, 2011 10:15:58 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

DFG JIT - register not unlocked after usage in ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=69122

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-29
Reviewed by Geoffrey Garen.

Some allocated register is not unlocked after the usage in ArithDiv.
Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".

  • dfg/DFGNode.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Location:
trunk/Source/JavaScriptCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r96381 r96389  
     12011-09-29  Yuqiang Xian  <yuqiang.xian@intel.com>
     2
     3        DFG JIT - register not unlocked after usage in ArithDiv
     4        https://bugs.webkit.org/show_bug.cgi?id=69122
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        Some allocated register is not unlocked after the usage in ArithDiv.
     9        Also there's a typo in "ENBALE_DFG_CONSISTENTCY_CHECK".
     10
     11        * dfg/DFGNode.h:
     12        * dfg/DFGSpeculativeJIT32_64.cpp:
     13        (JSC::DFG::SpeculativeJIT::compile):
     14        * dfg/DFGSpeculativeJIT64.cpp:
     15        (JSC::DFG::SpeculativeJIT::compile):
     16
    1172011-09-29  Mark Hahnenberg  <mhahnenberg@apple.com>
    218
  • trunk/Source/JavaScriptCore/dfg/DFGNode.h

    r96375 r96389  
    4545#endif
    4646// Consistency check contents compiler data structures.
    47 #define ENBALE_DFG_CONSISTENCY_CHECK 0
     47#define ENABLE_DFG_CONSISTENCY_CHECK 0
    4848// Emit a breakpoint into the head of every generated function, to aid debugging in GDB.
    4949#define ENABLE_DFG_JIT_BREAK_ON_EVERY_FUNCTION 0
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

    r96379 r96389  
    904904            m_jit.assembler().idivl_r(op2GPR);
    905905           
     906            if (temp2 != InvalidGPRReg)
     907                unlock(temp2);
     908
    906909            // Check that there was no remainder. If there had been, then we'd be obligated to
    907910            // produce a double result instead.
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

    r96379 r96389  
    999999            m_jit.assembler().idivl_r(op2GPR);
    10001000           
     1001            if (temp2 != InvalidGPRReg)
     1002                unlock(temp2);
     1003
    10011004            // Check that there was no remainder. If there had been, then we'd be obligated to
    10021005            // produce a double result instead.
Note: See TracChangeset for help on using the changeset viewer.