Changeset 96406 in webkit


Ignore:
Timestamp:
Sep 30, 2011 10:59:15 AM (13 years ago)
Author:
mhahnenberg@apple.com
Message:

Add getCallData to MethodTable in ClassInfo
​https://bugs.webkit.org/show_bug.cgi?id=69024

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added the getCallData to the MethodTable in the ClassInfo struct.

  • runtime/ClassInfo.h:

Source/WebCore:

No new tests.

  • WebCore.exp.in:

Changed getCallData from private to protected to allow subclasses who
don't override getCallData themselves to reference it in their own
method tables when calling the CREATE_METHOD_TABLE macro.

  • bridge/runtime_method.h:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r96391 r96406  
     12011-09-30  Mark Hahnenberg  <mhahnenberg@apple.com>
     2
     3        Add getCallData to MethodTable in ClassInfo
     4        https://bugs.webkit.org/show_bug.cgi?id=69024
     5
     6        Reviewed by Sam Weinig.
     7
     8        * JavaScriptCore.exp:
     9        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
     10
     11        Added the getCallData to the MethodTable in the ClassInfo struct.
     12        * runtime/ClassInfo.h:
     13
    1142011-09-29  Yuqiang Xian  <yuqiang.xian@intel.com>
    215

  • trunk/Source/JavaScriptCore/JavaScriptCore.exp

    r96381 r96406  
    252252__ZN3JSC4Yarr9interpretEPNS0_15BytecodePatternERKNS_7UStringEjjPi
    253253__ZN3JSC4callEPNS_9ExecStateENS_7JSValueENS_8CallTypeERKNS_8CallDataES2_RKNS_7ArgListE
     254__ZN3JSC6JSCell11getCallDataEPS0_RNS_8CallDataE
    254255__ZN3JSC6JSCell14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
    255256__ZN3JSC6JSCell14deletePropertyEPNS_9ExecStateEj

  • trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

    r96381 r96406  
    188188    ?get@Structure@JSC@@QAEIAAVJSGlobalData@2@ABVIdentifier@2@AAIAAPAVJSCell@2@@Z
    189189    ?get@Structure@JSC@@QAEIAAVJSGlobalData@2@PAVStringImpl@WTF@@AAIAAPAVJSCell@2@@Z
     190    ?getCallData@JSCell@JSC@@SA?AW4CallType@2@PAV12@AATCallData@2@@Z
    190191    ?getCallDataVirtual@JSCell@JSC@@UAE?AW4CallType@2@AATCallData@2@@Z
    191192    ?getConstructData@JSCell@JSC@@UAE?AW4ConstructType@2@AATConstructData@2@@Z

  • trunk/Source/JavaScriptCore/runtime/ClassInfo.h

    r96346 r96406  
    3434        typedef void (*VisitChildrenFunctionPtr)(JSCell*, SlotVisitor&);
    3535        VisitChildrenFunctionPtr visitChildren;
     36
     37        typedef CallType (*GetCallDataFunctionPtr)(JSCell*, CallData&);
     38        GetCallDataFunctionPtr getCallData;
    3639    };
    3740
    3841#define CREATE_METHOD_TABLE(ClassName) { \
    39         &ClassName::visitChildren \
     42        &ClassName::visitChildren, \
     43        &ClassName::getCallData \
    4044    }
    4145

  • trunk/Source/WebCore/ChangeLog

    r96404 r96406  
     12011-09-30  Mark Hahnenberg  <mhahnenberg@apple.com>
     2
     3        Add getCallData to MethodTable in ClassInfo
     4        https://bugs.webkit.org/show_bug.cgi?id=69024
     5
     6        Reviewed by Sam Weinig.
     7
     8        No new tests.
     9
     10        * WebCore.exp.in:
     11
     12        Changed getCallData from private to protected to allow subclasses who
     13        don't override getCallData themselves to reference it in their own
     14        method tables when calling the CREATE_METHOD_TABLE macro.
     15        * bridge/runtime_method.h:
     16
    1172011-09-30  Ned Holbrook  <nholbrook@apple.com>
    218

  • trunk/Source/WebCore/WebCore.exp.in

    r96346 r96406  
    16461646
    16471647#if USE(PLUGIN_HOST_PROCESS)
     1648__ZN3JSC13RuntimeMethod11getCallDataEPNS_6JSCellERNS_8CallDataE
    16481649__ZN3JSC13RuntimeMethod14finishCreationERNS_12JSGlobalDataERKNS_10IdentifierE
    16491650__ZN3JSC13RuntimeMethod18getCallDataVirtualERNS_8CallDataE
    … …  
    16531654__ZN3JSC13RuntimeMethodC2EPNS_14JSGlobalObjectEPNS_9StructureERN3WTF6VectorIPNS_8Bindings6MethodELm0EEE
    16541655__ZN3JSC8Bindings10RootObjectD1Ev
     1656__ZN3JSC8Bindings13RuntimeObject11getCallDataEPNS_6JSCellERNS_8CallDataE
    16551657__ZN3JSC8Bindings13RuntimeObject14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
    16561658__ZN3JSC8Bindings13RuntimeObject14finishCreationEPNS_14JSGlobalObjectE

  • trunk/Source/WebCore/bridge/runtime_method.h

    r96164 r96406  
    6363    void finishCreation(JSGlobalData&, const Identifier&);
    6464    static const unsigned StructureFlags = OverridesGetOwnPropertySlot | InternalFunction::StructureFlags;
     65    virtual CallType getCallDataVirtual(CallData&);
     66    static CallType getCallData(JSCell*, CallData&);
    6567
    6668private:
    … …  
    6870    virtual bool getOwnPropertySlot(ExecState*, const Identifier&, PropertySlot&);
    6971    virtual bool getOwnPropertyDescriptor(ExecState*, const Identifier&, PropertyDescriptor&);
    70     virtual CallType getCallDataVirtual(CallData&);
    71     static CallType getCallData(JSCell*, CallData&);
    7272
    7373    OwnPtr<Bindings::MethodList> _methodList;
Note: See TracChangeset for help on using the changeset viewer.