Changeset 96430 in webkit

Timestamp:

Sep 30, 2011 3:00:33 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
​https://bugs.webkit.org/show_bug.cgi?id=69169

Patch by James Robinson <​jamesr@chromium.org> on 2011-09-30
Reviewed by Darin Fisher.

If the compositor does not process the input event the embedder might want to do something with it - for
example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
open a new tab. This passes that state through the didHandleInputEvent callback.

• public/WebCompositorClient.h:
• src/WebCompositorImpl.cpp:

(WebKit::WebCompositorImpl::handleInputEvent):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebCompositorClient.h (modified) (1 diff)
• src/WebCompositorImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-30  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Pass a processed bool in WebCompositorClient::didHandleInputEvent to indicate if the event was processed
+        https://bugs.webkit.org/show_bug.cgi?id=69169
+
+        Reviewed by Darin Fisher.
+
+        If the compositor does not process the input event the embedder might want to do something with it - for
+        example, if the input event type is part of a CTRL+T keyboard accelerator sequence the browser might want to
+        open a new tab. This passes that state through the didHandleInputEvent callback.
+
+        * public/WebCompositorClient.h:
+        * src/WebCompositorImpl.cpp:
+        (WebKit::WebCompositorImpl::handleInputEvent):
+
 2011-09-30  Elliot Poger  <epoger@google.com>
 

trunk/Source/WebKit/chromium/public/WebCompositorClient.h

@@ -33 +33 @@
     // Callbacks invoked from the compositor thread.
     virtual void willShutdown() = 0;
-    virtual void didHandleInputEvent() = 0;
+    virtual void didHandleInputEvent(bool processed) = 0;
 
 protected:

trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp

@@ -61 +61 @@
 {
     // FIXME: Do something interesting with the event here.
-    m_client->didHandleInputEvent();
+    m_client->didHandleInputEvent(false);
 }