Changeset 96473 in webkit


Ignore:
Timestamp:
Oct 2, 2011 10:18:28 AM (13 years ago)
Author:
abarth@webkit.org
Message:

Rip out half-backed garden-o-matic features in preparation for wider use
​https://bugs.webkit.org/show_bug.cgi?id=69226

This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
Location:
trunk/Tools
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js

    r95069 r96473  
    7272});
    7373
    74 test("rebaseline", 7, function() {
     74test("rebaseline", 6, function() {
    7575    var simulator = new NetworkSimulator();
    7676
    … …  
    8383    simulator.ajax = function(options)
    8484    {
    85         ok(options.url.indexOf('/ping') != -1);
     85        if (options.url.indexOf('/ping') != -1)
     86            ok(false, 'Recieved non-ping ajax request.');
    8687        simulator.scheduleCallback(options.success);
    8788    };

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

    r95370 r96473  
    4343    'Webkit Mac10.6': {version: 'snowleopard'},
    4444    'Webkit Mac10.6 (dbg)': {version: 'snowleopard', debug: true},
    45     'Webkit Mac10.5 (CG)': {version: 'leopard'},
    46     'Webkit Mac10.5 (CG)(dbg)(1)': {version: 'leopard', debug: true},
    47     'Webkit Mac10.5 (CG)(dbg)(2)': {version: 'leopard', debug: true},
    48     'Webkit Mac10.6 (CG)': {version: 'snowleopard'},
    49     'Webkit Mac10.6 (CG)(dbg)': {version: 'snowleopard', debug: true},
     45    'Webkit Mac10.5 (CG)': {version: 'leopard', isCG: true},
     46    'Webkit Mac10.5 (CG)(dbg)(1)': {version: 'leopard', isCG: true, debug: true},
     47    'Webkit Mac10.5 (CG)(dbg)(2)': {version: 'leopard', isCG: true, debug: true},
     48    'Webkit Mac10.6 (CG)': {version: 'snowleopard', isCG: true},
     49    'Webkit Mac10.6 (CG)(dbg)': {version: 'snowleopard', isCG: true, debug: true},
    5050};
    5151

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js

    r96183 r96473  
    3232
    3333var g_unexpectedFailuresController = null;
    34 var g_failuresController = null;
    3534
    3635var g_failingBuilders = null;
    … …  
    7877    g_unexpectedFailuresController = new controllers.UnexpectedFailures(model.state, unexpectedFailuresView, onebarController);
    7978
    80     var failuresView = new ui.notifications.Stream();
    81     g_failuresController = new controllers.Failures(model.state, failuresView, onebarController);
    82 
    8379    g_info = new ui.notifications.Stream();
    8480    g_failingBuilders = new controllers.FailingBuilders(g_info);
    … …  
    9490    summary.appendChild(unexpectedFailuresView);
    9591
    96     var failures = onebar.failures();
    97     failures.appendChild(failuresView);
    98 
    9992    update();
    10093});

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

    r96329 r96473  
    6060                '<li><a href="#summary">Summary</a></li>' +
    6161                '<li><a href="#results">Results</a></li>' +
    62                 '<li><a href="#commits">Commits</a></li>' +
    63                 '<li><a href="#failures">Failures</a></li>' +
    6462            '</ul>' +
    6563            '<div id="summary"></div>' +
    66             '<div id="results"></div>' +
    67             '<div id="commits">Coming soon...</div>' +
    68             '<div id="failures"></div>';
     64            '<div id="results"></div>';
    6965        this._tabNames = [
    7066            'summary',
    7167            'results',
    72             'commits',
    73             'failures',
    7468        ]
    7569        this._tabs = $(this).tabs({
    76             disabled: [1, 2, 3],
     70            disabled: [1],
    7771        });
    7872    },
    … …  
    9286    {
    9387        return this.tabNamed('results');
    94     },
    95     failures: function()
    96     {
    97         return this.tabNamed('failures');
    9888    },
    9989    select: function(tabName)
    … …  
    163153        this.addMessage(message);
    164154        this.appendChild(new ui.actions.List([new ui.actions.Close()]));
    165         $(this).bind('close', statusView.close.bind(statusView));
     155        $(this).bind('close', this.close.bind(this));
    166156    }
    167157});

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

    r95068 r96473  
    3434    init: function(configuration)
    3535    {
     36        if (configuration.version)
     37            this._addSpan('version', configuration.version);
     38        if (configuration.isCG)
     39            this._addSpan('graphics', 'CG');
    3640        if (configuration.is64bit)
    3741            this._addSpan('architecture', '64-bit');
    38         if (configuration.version)
    39             this._addSpan('version', configuration.version);
    4042        this._configuration = configuration;
    4143        this.target = '_blank';
    … …  
    4951    equals: function(configuration)
    5052    {
    51         return this._configuration.is64bit == configuration.is64bit && this._configuration.version == configuration.version;
     53        return this._configuration.is64bit == configuration.is64bit && this._configuration.isCG == configuration.isCG && this._configuration.version == configuration.version;
    5254    }
    5355});

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js

    r95595 r96473  
    4242    equal(configuration.outerHTML, '<a target="_blank"></a>');
    4343    configuration = new ui.failures.Configuration({is64bit: true, version: 'lucid'});
    44     equal(configuration.outerHTML, '<a target="_blank"><span class="architecture">64-bit</span><span class="version">lucid</span></a>');
     44    equal(configuration.outerHTML, '<a target="_blank"><span class="version">lucid</span><span class="architecture">64-bit</span></a>');
    4545    configuration = new ui.failures.Configuration({version: 'xp'});
    4646    equal(configuration.outerHTML, '<a target="_blank"><span class="version">xp</span></a>');
    … …  
    9494                '<td>TEXT</td>' +
    9595                '<td></td>' +
    96                 '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
     96                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
    9797            '</tr>' +
    9898            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    105105            '<tr class="IMAGE+TEXT">' +
    106106                '<td>IMAGE+TEXT</td>' +
    107                 '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
     107                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span><span class="graphics">CG</span></a></td>' +
    108108                '<td></td>' +
    109109            '</tr>' +
    … …  
    111111                '<td>TEXT</td>' +
    112112                '<td></td>' +
    113                 '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
     113                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
    114114            '</tr>' +
    115115            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    122122            '<tr class="IMAGE+TEXT">' +
    123123                '<td>IMAGE+TEXT</td>' +
    124                 '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
     124                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span><span class="graphics">CG</span></a></td>' +
    125125                '<td></td>' +
    126126            '</tr>' +
    … …  
    128128                '<td>TEXT</td>' +
    129129                '<td></td>' +
    130                 '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
     130                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
    131131            '</tr>' +
    132132            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

    r96183 r96473  
    101101        this._description = this.appendChild(document.createElement('div'));
    102102        this._description.className = 'description';
    103         this.appendChild(new ui.actions.List([
    104             new ui.actions.Blame(),
    105             new ui.actions.Rollout(),
    106         ]));
    107103    }
    108104});
    … …  
    160156            new ui.actions.Examine().makeDefault(),
    161157            new ui.actions.Rebaseline(),
    162             new ui.actions.UpdateExpectations(),
    163158        ]));
    164159        this._testNameList = [];

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

    r96074 r96473  
    9494                '<span class="reviewer">reviewer</span>' +
    9595            '</span>' +
    96         '</div>' +
    97         '<ul class="actions">' +
    98             '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
    99             '<li><button class="action" title="Rolls out this revision.">Roll out</button></li>' +
    100         '</ul>');
     96        '</div>');
    10197});
    10298
    … …  
    118114                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    119115                    '<li><button class="action">Rebaseline</button></li>' +
    120                     '<li><button class="action">Mark as Expected</button></li>' +
    121116                '</ul>' +
    122117            '</div>' +
    … …  
    141136                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    142137                    '<li><button class="action">Rebaseline</button></li>' +
    143                     '<li><button class="action">Mark as Expected</button></li>' +
    144138                '</ul>' +
    145139            '</div>' +
    … …  
    165159                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    166160                    '<li><button class="action">Rebaseline</button></li>' +
    167                     '<li><button class="action">Mark as Expected</button></li>' +
    168161                '</ul>' +
    169162            '</div>' +
    … …  
    191184                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    192185                    '<li><button class="action">Rebaseline</button></li>' +
    193                     '<li><button class="action">Mark as Expected</button></li>' +
    194186                '</ul>' +
    195187            '</div>' +
    … …  
    204196                        '</span>' +
    205197                    '</div>' +
    206                     '<ul class="actions">' +
    207                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
    208                         '<li><button class="action" title="Rolls out this revision.">Roll out</button></li>' +
    209                     '</ul>' +
    210198                '</li>' +
    211199            '</ul>' +
    … …  
    222210                        '<td>TEXT</td>' +
    223211                        '<td></td>' +
    224                         '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
     212                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
    225213                    '</tr>' +
    226214                    '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    237225                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    238226                    '<li><button class="action">Rebaseline</button></li>' +
    239                     '<li><button class="action">Mark as Expected</button></li>' +
    240227                '</ul>' +
    241228            '</div>' +
    … …  
    250237                        '</span>' +
    251238                    '</div>' +
    252                     '<ul class="actions">' +
    253                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
    254                         '<li><button class="action" title="Rolls out this revision.">Roll out</button></li>' +
    255                     '</ul>' +
    256239                '</li>' +
    257240            '</ul>' +
    … …  
    268251                        '<td>TEXT</td>' +
    269252                        '<td></td>' +
    270                         '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
     253                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
    271254                    '</tr>' +
    272255                    '<tr class="BUILDING" style="">' +
    273256                        '<td>BUILDING</td>' +
    274                         '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
     257                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span><span class="graphics">CG</span></a></td>' +
    275258                        '<td></td>' +
    276259                    '</tr>' +
    … …  
    287270                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    288271                    '<li><button class="action">Rebaseline</button></li>' +
    289                     '<li><button class="action">Mark as Expected</button></li>' +
    290272                '</ul>' +
    291273            '</div>' +
    … …  
    300282                        '</span>' +
    301283                    '</div>' +
    302                     '<ul class="actions">' +
    303                         '<li><button class="action" title="Blames this failure on this revision.">Blame</button></li>' +
    304                         '<li><button class="action" title="Rolls out this revision.">Roll out</button></li>' +
    305                     '</ul>' +
    306284                '</li>' +
    307285            '</ul>' +
    … …  
    333311                    '<li><button class="action default" title="Examine these failures in detail.">Examine</button></li>' +
    334312                    '<li><button class="action">Rebaseline</button></li>' +
    335                     '<li><button class="action">Mark as Expected</button></li>' +
    336313                '</ul>' +
    337314            '</div>' +

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css

    r96074 r96473  
    4848
    4949ol.notifications div.how {
    50     width: 300px;
     50    width: 350px;
    5151}
    5252
    … …  
    106106
    107107        ol.notifications>li ul.causes>li>div.description>a {
    108             padding: 0 20px 0 10px;
     108            padding: 5px 10px 5px 10px;
     109            margin: -5px 10px -2px 0;
    109110            border-radius: 4px;
     111            display: inline-block;
    110112        }
    111113
    112114        ol.notifications>li ul.causes>li:hover>div.description>a {
    113115            background-color: #555;
    114             padding: 5px 10px 5px 10px;
    115             margin: -5px 10px -1px 0;
    116116            color: White;
    117             display: inline-block;
    118117        }
    119118
    … …  
    172171    table-layout: fixed;
    173172    font-size: 11px;
    174     width: 300px;
     173    width: 350px;
    175174}
    176175
    … …  
    183182    }
    184183
     184    ol.notifications table.failures tbody td:first-child {
     185        width: 20%;
     186    }
     187
    185188    ol.notifications table.failures tbody td {
    186         width: 33%;
     189        width: 40%;
    187190        padding: 2px;
    188191    }
    … …  
    209212
    210213        ol.notifications table.failures tbody td:nth-child(n+2)>a>span.architecture {
    211             padding: 0 3px 0 0;
    212         }
     214            padding: 0 2px;
     215        }
     216
     217        ol.notifications table.failures tbody td:nth-child(n+2)>a>span.graphics {
     218            padding: 0 2px;
     219        }

  • trunk/Tools/ChangeLog

    r96468 r96473  
     12011-10-02  Adam Barth  <abarth@webkit.org>
     2
     3        Rip out half-backed garden-o-matic features in preparation for wider use
     4        https://bugs.webkit.org/show_bug.cgi?id=69226
     5
     6        This patch rips out a bunch of half-baked features and cleans up a
     7        bunch of small nits with the core set of features.  We're going to ask
     8        more folks to start using the tool, and having a bunch of half-baked
     9        features around is distracting.  We can add these features back under a
     10        flag and interate on them after we've got the core functionality
     11        nailed.
     12
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
     17        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
     18        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
     19        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
     20        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
     21        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
     22
    1232011-10-01  Brent Fulgham  <bfulgham@webkit.org>
    224
Note: See TracChangeset for help on using the changeset viewer.