Changeset 96565 in webkit


Ignore:
Timestamp:
Oct 3, 2011 7:00:14 PM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic should remove builders from the failure grid once they start to pass
​https://bugs.webkit.org/show_bug.cgi?id=69309

Unreviewed. dglazkov is on vacation. I need to interest someone else
in reviewing these patches.

This patch follows the update/purge model from UpdateTracker. This
patch is less awesome than it could be because it causes the UI to
flash slightly. In a future patch, we'll want to use these
update/purge notifications to update the UI without flashing. However,
that's not such a big deal because this UI is hidden in the default
view.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

    r96329 r96565  
    132132            failure.dismiss();
    133133        });
     134        this._testFailures.forEach(function(failure) {
     135            failure.purge();
     136        });
    134137    },
    135138    onExamine: function(failures)

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

    r96473 r96565  
    7676        titles.insertCell().textContent = 'type';
    7777        this._body = this.appendChild(document.createElement('tbody'));
    78         this._resultRows = {};
    79         // Add the BUILDING row eagerly so that it appears last.
    80         this._rowByResult(kBuildingResult);
    81         $(this._resultRows[kBuildingResult]).hide();
     78        this._reset();
    8279    },
    8380    _rowByResult: function(result)
    … …  
    9592        return row;
    9693    },
    97     removeResultRows: function()
     94    update: function(resultsByBuilder)
    9895    {
    99         Object.keys(this._resultRows).forEach(function(result) {
    100             var row = this._resultRows[result];
    101             row.parentNode.removeChild(row);
    102         }, this);
    103         this._resultRows = {};
    104     },
    105     add: function(resultsByBuilder)
    106     {
     96        if (this._pendingReset)
     97            this._reset();
     98
     99        if (!resultsByBuilder)
     100            return;
     101
    107102        Object.keys(resultsByBuilder).forEach(function(builderName) {
    108103            var configuration = config.kBuilders[builderName];
     104            if (!configuration)
     105                throw "Unknown builder name: " + builderName;
    109106            var row = this._rowByResult(resultsByBuilder[builderName].actual);
    110107            var cell = cellByBuildType(row, configuration);
    … …  
    113110            cell.appendChild(new ui.failures.Configuration(configuration)).href = ui.displayURLForBuilder(builderName);
    114111        }, this);
     112    },
     113    purge: function()
     114    {
     115        this._pendingReset = true;
     116    },
     117    _reset: function()
     118    {
     119        this._pendingReset = false;
     120        this._resultRows = {};
     121        $(this._body).empty();
     122        // Add the BUILDING row eagerly so that it appears last.
     123        this._rowByResult(kBuildingResult);
     124        $(this._resultRows[kBuildingResult]).hide();
    115125    }
    116126});

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js

    r96473 r96565  
    5151});
    5252
    53 test('FailureGrid', 9, function() {
     53test('FailureGrid', 10, function() {
    5454    var grid = new ui.failures.FailureGrid();
    5555    deepEqual(Object.getOwnPropertyNames(grid.__proto__).sort(), [
     56        "_reset",
    5657        "_rowByResult",
    57         "add",
    5858        "init",
    59         "removeResultRows",
     59        "purge",
     60        "update"
    6061    ]);
    6162    equal(grid.outerHTML, '<table class="failures">' +
    … …  
    7475    '</table>');
    7576    equal(row.outerHTML, '<tr class="TEXT"><td>TEXT</td><td></td><td></td></tr>');
    76     grid.add({});
     77    grid.update({});
    7778    equal(grid.outerHTML, '<table class="failures">' +
    7879        '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
    … …  
    8788        grid.update({'Atari': {}})
    8889    });
    89     grid.add({'Webkit Linux (dbg)(1)': { actual: 'TEXT'}});
     90    grid.update({'Webkit Linux (dbg)(1)': { actual: 'TEXT'}});
    9091    equal(grid.outerHTML, '<table class="failures">' +
    9192        '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
    … …  
    99100        '</tbody>' +
    100101    '</table>');
    101     grid.add({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
     102    grid.update({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
    102103    equal(grid.outerHTML, '<table class="failures">' +
    103104        '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
    … …  
    116117        '</tbody>' +
    117118    '</table>');
    118     grid.add({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
     119    grid.update({'Webkit Mac10.5 (CG)': { actual: 'IMAGE+TEXT'}});
    119120    equal(grid.outerHTML, '<table class="failures">' +
    120121        '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
    … …  
    133134        '</tbody>' +
    134135    '</table>');
     136    grid.purge();
     137    grid.update({'Webkit Linux (dbg)(1)': { actual: 'TEXT'}});
     138    equal(grid.outerHTML, '<table class="failures">' +
     139        '<thead><tr><td>type</td><td>release</td><td>debug</td></tr></thead>' +
     140        '<tbody>' +
     141            '<tr class="TEXT">' +
     142                '<td>TEXT</td>' +
     143                '<td></td>' +
     144                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="version">lucid</span><span class="architecture">64-bit</span></a></td>' +
     145            '</tr>' +
     146            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
     147        '</tbody>' +
     148    '</table>');
    135149});
    136150

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

    r96473 r96565  
    205205        this._commitDataPinned = false;
    206206    },
     207    purge: function() {
     208        this._where.purge();
     209    },
    207210    updateBuilderResults: function(resultNodesByBuilder)
    208211    {
    209         this._where.add(resultNodesByBuilder);
     212        this._where.update(resultNodesByBuilder);
    210213    },
    211214    addFailureAnalysis: function(failureAnalysis)
    212215    {
     216        this.updateBuilderResults(failureAnalysis.resultNodesByBuilder);
    213217        if (!ui.notifications.FailingTests.prototype.addFailureAnalysis.call(this, failureAnalysis))
    214218            return false;
    215         this.updateBuilderResults(failureAnalysis.resultNodesByBuilder);
    216219    },
    217220    pinToCommitData: function(commitData)

  • trunk/Tools/ChangeLog

    r96560 r96565  
     12011-10-03  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic should remove builders from the failure grid once they start to pass
     4        https://bugs.webkit.org/show_bug.cgi?id=69309
     5
     6        Unreviewed.  dglazkov is on vacation.  I need to interest someone else
     7        in reviewing these patches.
     8
     9        This patch follows the update/purge model from UpdateTracker.  This
     10        patch is less awesome than it could be because it causes the UI to
     11        flash slightly.  In a future patch, we'll want to use these
     12        update/purge notifications to update the UI without flashing.  However,
     13        that's not such a big deal because this UI is hidden in the default
     14        view.
     15
     16        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
     17        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
     18        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
     19        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
     20
    1212011-10-03  David Levin  <levin@chromium.org>
    222
    … …  
    91111        (I'm leaving the company and my @openbossa.org will be no more)
    92112
    93         * Scripts/webkitpy/common/config/committers.py:
    94 
    95 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
    96 
    97         [GTK] Fix memory leak when loading url
    98         https://bugs.webkit.org/show_bug.cgi?id=69247
    99 
    100         Reviewed by Martin Robinson.
    101 
    102         Release URL created with WKURLCreateWithUTF8CString().
    103 
    104         * MiniBrowser/gtk/BrowserWindow.c:
    105         (activateUriEntryCallback):
    106         * MiniBrowser/gtk/main.c:
    107         (loadURI):
    108 
    109 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
    110 
    111         Unreviewed. Add Zoltán Árvai as contributor.
    112 
    113         * Scripts/webkitpy/common/config/committers.py:
    114 
    115 2011-10-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
    116 
    117         [EFL] DRT: Add DumpHistoryItem.{cpp,h}
    118         https://bugs.webkit.org/show_bug.cgi?id=63992
    119 
    120         Reviewed by Antonio Gomes.
    121 
    122         This is the code responsible for dumping the back and forward history
    123         list.
    124 
    125         * DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
    126         (dumpHistoryItem):
    127         (dumpBackForwardListForWebView):
    128         (dumpBackForwardListForWebViews):
    129         * DumpRenderTree/efl/DumpHistoryItem.h: Added.
    130 
    131 2011-10-03  Zeno Albisser  <zeno.albisser@nokia.com>
    132 
    133         [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
    134         https://bugs.webkit.org/show_bug.cgi?id=69223
    135 
    136         WebKitTestRunner must include Qt / qnamespace header
    137         to get a definition of Qt::MouseButtons.
    138 
    139         Reviewed by Andreas Kling.
    140 
    141         * WebKitTestRunner/EventSenderProxy.h:
    142 
    143 2011-10-03  Csaba Osztrogonác  <ossy@webkit.org>
    144 
    145         Unreviewed. Add Zoltán Árvai as contributor.
    146 
    147         * Scripts/webkitpy/common/config/committers.py:
    148 
    149 2011-10-02  Adam Barth  <abarth@webkit.org>
    150 
    151         Clean up obsolete code in gardeningserver.py related to
    152         STATIC_FILE_NAMES.  Rather than serve the UI via the Python HTTP
    153         server, we just serve it off the filesystem directly.
    154 
    155         We had planned to serve the UI off build.webkit.org, but that server is
    156         somewhat slow.  We'll probably serve the UI of some web server, but
    157         we'll need to work that out later.
    158 
    159         * Scripts/webkitpy/tool/commands/gardenomatic.py:
    160         * Scripts/webkitpy/tool/servers/gardeningserver.py:
    161 
    162 2011-10-02  Adam Barth  <abarth@webkit.org>
    163 
    164         Rip out half-backed garden-o-matic features in preparation for wider use
    165         https://bugs.webkit.org/show_bug.cgi?id=69226
    166 
    167         This patch rips out a bunch of half-baked features and cleans up a
    168         bunch of small nits with the core set of features.  We're going to ask
    169         more folks to start using the tool, and having a bunch of half-baked
    170         features around is distracting.  We can add these features back under a
    171         flag and interate on them after we've got the core functionality
    172         nailed.
    173 
    174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
    175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
    176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
    177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
    178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
    179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
    180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
    181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
    182113        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
    183114
    … …  
    1081410745
    1081510746        Unreviewed. Skipping a few tests which fail due to differing output
    10816         in recent ApplicationCache quota tests. Reenabling the tests is
    10817         tracked by <http://webkit.org/b/64410>.
    10818 
    10819         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
    10820         (WebCore::DumpRenderTree::dumpApplicationCacheQuota): This should
    10821         have been a space, not a newline.
    10822 
    10823 2011-07-12  Adam Barth  <abarth@webkit.org>
    10824 
    10825         garden-o-matic should display regression ranges
    10826         https://bugs.webkit.org/show_bug.cgi?id=64407
    10827 
    10828         Reviewed by Dimitri Glazkov.
    10829 
    10830         This patch computes a regression range for a failure by intersecting
    10831         the regression ranges seen by the various bots.  We make the underlying
    10832         assumption that a test is only failing due to one revision at any given
    10833         moment.  If that's not true, this code probably explodes.
    10834 
    10835         The regression ranges appear asynchronously, which might be a jarring
    10836         UI.  We'll have to experiment to see.
    10837 
    10838         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
    10839         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
    10840         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    10841         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
    10842         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
    10843         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
    10844         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
    10845 
    10846 2011-07-12  Adam Barth  <abarth@webkit.org>
    10847 
    10848         cr-linux-ews should run pixel tests
    10849         https://bugs.webkit.org/show_bug.cgi?id=64394
    10850 
    10851         Reviewed by Ojan Vafai.
    10852 
    10853         This patch enabled pixel test on the cr-linux-ews.  Running a quick
    10854         test on the bots, it looks like we have five pixel failures, related to
    10855         some missing fonts.  I've also made the bots skip failing tests to
    10856         avoid uploading huge zip files to bugs.webkit.org (with all the exected
    10857         IMAGE failures).
    10858 
    10859         * Scripts/webkitpy/common/config/ports.py:
    10860         * Scripts/webkitpy/common/config/ports_unittest.py:
    10861 
    10862 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
    10863 
    10864         ApplicationCache update should not immediately fail when reaching per-origin quota
    10865         https://bugs.webkit.org/show_bug.cgi?id=64177
    10866 
    10867         Reviewed by Alexey Proskuryakov.
    10868 
    10869         Add layoutTestController.disallowIncreaseForApplicationCacheQuota()
    10870         to disable the default behavior of raising the default per-origin
    10871         quota to 5MB when reached. This allows us to test what happens
    10872         when the quota is reached and not increased.
    10873 
    10874         * DumpRenderTree/LayoutTestController.cpp:
    10875         (LayoutTestController::LayoutTestController):
    10876         (disallowIncreaseForApplicationCacheQuotaCallback):
    10877         (LayoutTestController::staticFunctions):
    10878         * DumpRenderTree/LayoutTestController.h:
    10879         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
    10880         (LayoutTestController::setDisallowIncreaseForApplicationCacheQuota):
    10881         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
    10882         (LayoutTestController::reset):
    10883         * DumpRenderTree/qt/LayoutTestControllerQt.h:
    10884         (LayoutTestController::disallowIncreaseForApplicationCacheQuota):
    10885         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
    10886         Expose a function to prevent automatically increasing the per-origin
    10887         quota when the quota is reached. This allows us to test what happens
    10888         when a user would "disallow" a quota increase.
    10889 
    10890         * DumpRenderTree/mac/UIDelegate.mm:
    10891         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:spaceNeeded:]):
    10892         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
    10893         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
    10894         Respect the new disallowIncrease flag and dump the spaceNeeded values
    10895         for ports that implement application cache quotas.
    10896 
    10897 2011-07-12  Ojan Vafai  <ojan@chromium.org>
    10898 
    10899         fix flakiness dashboard to work with new crash log filenames
    10900         https://bugs.webkit.org/show_bug.cgi?id=64393
    10901 
    10902         Reviewed by Adam Barth.
    10903 
    10904         * TestResultServer/static-dashboards/flakiness_dashboard.html:
    10905 
    10906 2011-07-12  Adam Barth  <abarth@webkit.org>
    10907 
    10908         Add a happy animation to garden-o-matic when there are no failures
    10909         https://bugs.webkit.org/show_bug.cgi?id=64382
    10910 
    10911         Reviewed by Ojan Vafai.
    10912 
    10913         As requested by Ojan.
    10914 
    10915         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
    10916         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
    10917         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Added.
    10918         * Scripts/webkitpy/tool/servers/gardeningserver.py:
    10919 
    10920 2011-07-12  Adam Barth  <abarth@webkit.org>
    10921 
    10922         sheriffbot can't perform rollouts
    10923         https://bugs.webkit.org/show_bug.cgi?id=64370
    10924 
    10925         Reviewed by Eric Seidel.
    10926 
    10927         Now that we're not updating the working copy before processing every
    10928         IRC message, the rollout command needs to update it manually.
    10929 
    10930         * Scripts/webkitpy/tool/bot/irc_command.py:
    10931         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
    10932 
    10933 2011-07-12  Adam Barth  <abarth@webkit.org>
    10934 
    10935         Fix the grammar in the FIXME comment.
    10936 
    10937         * Scripts/webkitpy/common/net/resultsjsonparser.py:
    10938 
    10939 2011-07-12  Eric Seidel  <eric@webkit.org>
    10940 
    10941         NRWT should open test results page with Safari trunk, not the system provided one on Mac
    10942         https://bugs.webkit.org/show_bug.cgi?id=64346
    10943 
    10944         Reviewed by Adam Barth.
    10945 
    10946         To fix this I implemented Port.show_results_html_file in Mac, Gtk and Qt ports with
    10947         implementations (mostly) matching those found in old-run-webkit-tests.
    10948         There are still some minor differences for Qt which Qt hackers may wish to tweak.
    10949 
    10950         I had to add a WebKitPort._port_flag_for_scripts method (similar to flag() in common.config.ports.py)
    10951         for the Qt/Gtk ports which always require a flag passed to scripts.
    10952 
    10953         While trying to test this, I found that FactoryTest.test_chromium_gpu_linux
    10954         was using a real filesystem (due to assert_platform) which due to
    10955         global variables in config.py was causing set-webkit-configuration to have
    10956         an affect on unit test results!  So I fixed this by making FactoryTest.assert_port
    10957         pass a mock file system whenever calling factory.get.
    10958 
    10959         Unfortunately TestPort was depending on always being passed a None filesystem
    10960         and asserting filesystem._tests (only true for unit_test_filesystem()).
    10961         So I just removed the FactoryTest.test_test and FactoryTest.test_dryrun tests
    10962         deciding that they were pretty much useless anyway.  If others feel strongly
    10963         I'm happy to fix this in a different way.
    10964 
    10965         * Scripts/webkitpy/common/system/executive.py:
    10966          - default arguments in python are screwy.  They use a single shared
    10967            instance, so it's better to use argument=None and then argument = argument or Default()
    10968            if you have any chance of mutating (or returning) the default argument.
    10969         * Scripts/webkitpy/layout_tests/port/config.py:
    10970          - This code is wrong.  We don't need to use a global variable here (as far as I can tell).
    10971            I'm not fixing it in this patch, but I've marked it with a FIXME and we can convert to
    10972            storing the results of the read on the Config object (which should only be created once during normal operation).
    1097310747           Unit tests shouldn't be hitting the disk anyway.  It's possible Config should move off of Port and onto Tool/Host directly.
    1097410748        * Scripts/webkitpy/layout_tests/port/factory.py:
    … …  
    2193421708        Reviewed by Eric Seidel.
    2193521709
    21936         webkit-patch --non-interactive is incompatible with new-run-webkit-tests
    21937         https://bugs.webkit.org/show_bug.cgi?id=59919
    21938 
    21939         new-run-webkit-tests doesn't support --wait-for-httpd (because it
    21940         always waits for HTTPD, as I understand things).  It turns out we're
    21941         not really using this flag for anything, so we should just remove it.
    21942 
    21943         * Scripts/webkitpy/tool/steps/runtests.py:
    21944         * Scripts/webkitpy/tool/steps/steps_unittest.py:
    21945 
    21946 2011-05-01  Eric Seidel  <eric@webkit.org>
    21947 
    21948         Reviewed by Adam Barth.
    21949 
    21950         The bots should learn from expected failures without having to retry
    21951         https://bugs.webkit.org/show_bug.cgi?id=59279
    21952 
    21953         Rather than re-trying the whole patch, we can just check whether we now
    21954         expect the failures we see with the patch applied, saving a lot of time.
    21955 
    21956         This patch also teaches the CommitQueue how to reject patches even
    21957         when the tree is red using the new unexpected_failures() method on
    21958         ExpectedFailures.
    21959 
    21960         Finally in testing we found a bug in ExpectedFailures where it would
    21961         "trust" results which had many many failures, due to using an
    21962         equal sign instead of a less-than sign.
    21963 
    21964         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
    21965         * Scripts/webkitpy/tool/bot/expectedfailures.py
    21966         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
    21967         * Scripts/webkitpy/tool/bot/patchanalysistask.py
    21968 
    21969 
    21970 2011-05-02  Adam Barth  <abarth@webkit.org>
    21971 
    21972         Reviewed by Eric Seidel.
    21973 
    21974         workspace.py fails to import ScriptError
    21975         https://bugs.webkit.org/show_bug.cgi?id=59915
    21976 
    21977         If the workspace fails to create a zip, webkitpy crashes instead of
    21978         handling the error as expected.
    21979 
    21980         * Scripts/webkitpy/common/system/workspace.py:
    21981         * Scripts/webkitpy/common/system/workspace_unittest.py:
    21982         * Scripts/webkitpy/tool/mocktool.py:
    21983 
    21984 2011-05-01  Adam Barth  <abarth@webkit.org>
    21985 
    21986         Remove unadvertantly added file.
    21987 
    21988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
    21989 
    21990 2011-05-01  Adam Barth  <abarth@webkit.org>
    21991 
    21992         Reviewed by Eric Seidel.
    21993 
    21994         expectedfailures.py should report the unexpected failures when asked
    21995         https://bugs.webkit.org/show_bug.cgi?id=59916
    21996 
    21997         This information is useful when the EWS runs tests.
    21998 
    21999         * Scripts/webkitpy/tool/bot/expectedfailures.py:
    22000         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
    22001 
    22002 2011-05-01  Adam Barth  <abarth@webkit.org>
    22003 
    22004         Reviewed by Eric Seidel.
    22005 
    22006         JSONTestResult needs to handle multiple results
    22007         https://bugs.webkit.org/show_bug.cgi?id=59269
    22008 
    22009         This case occurs when a test is flaky because NRWT will run the test
    22010         twice and report both results as "actual."
    22011 
    22012         * Scripts/webkitpy/common/net/resultsjsonparser.py:
    22013         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
    22014 
    22015 2011-05-01  Adam Barth  <abarth@webkit.org>
    22016 
    22017         Reviewed by Eric Seidel.
    22018 
    22019         Move checkout/api.py to checkout/checkout.py
    22020         https://bugs.webkit.org/show_bug.cgi?id=59906
    22021 
    22022         This is more consistent with Python style.
    22023 
    22024         * Scripts/webkitpy/common/checkout/__init__.py:
    22025         * Scripts/webkitpy/common/checkout/scm_unittest.py:
    22026         * Scripts/webkitpy/common/host.py:
    22027         * Scripts/webkitpy/tool/main.py:
    22028 
    22029 2011-05-01  Eric Seidel  <eric@webkit.org>
    22030 
    22031         Reviewed by Adam Barth.
    22032 
    22033         scm.py should be split into many pieces
    22034         https://bugs.webkit.org/show_bug.cgi?id=59908
    22035 
    22036         Forgot an AuthenticationError import.
    22037 
    22038         * Scripts/webkitpy/common/checkout/scm/git.py:
    22039         * Scripts/webkitpy/common/checkout/scm/svn.py:
    22040 
    22041 2011-05-01  Arno Renevier  <arno@renevier.net>
    22042 
    22043         Reviewed by Eric Seidel.
    22044 
    22045         wrong exception raised in Lighttpd start method
    22046         https://bugs.webkit.org/show_bug.cgi?id=59283
    22047 
    22048         raise standard Exception instead of non existent
    22049         google.httpd_utils.HttpdNotStarted
    22050 
    22051         * Scripts/webkitpy/layout_tests/port/http_server.py:
    22052 
    22053 2011-05-01  Eric Seidel  <eric@webkit.org>
    22054 
    22055         Reviewed by Adam Barth.
    22056 
    22057         scm.py should be split into many pieces
    22058         https://bugs.webkit.org/show_bug.cgi?id=59908
    22059 
    22060         * Scripts/webkitpy/common/checkout/scm/__init__.py:
    22061         * Scripts/webkitpy/common/checkout/scm/commitmessage.py: Added.
    22062         * Scripts/webkitpy/common/checkout/scm/git.py: Added.
    22063         * Scripts/webkitpy/common/checkout/scm/scm.py:
    22064         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
    22065         * Scripts/webkitpy/common/checkout/scm/svn.py: Added.
    22066 
    22067 2011-05-01  Eric Seidel  <eric@webkit.org>
    22068 
    22069         Reviewed by Adam Barth.
    22070 
    22071         Make most scm.py tests pass in preparation for splitting them up
    22072         https://bugs.webkit.org/show_bug.cgi?id=59904
    22073 
    22074         There is one remaining failure:
    22075         webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
    22076         which identifies a difference between the SVN and Git versions of the
    22077         SCM api.  I'm not going to bother fixing that until we split out all
    22078         the tests.
    22079 
    22080         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
    22081 
    22082 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
    22083 
    22084         [WIN] Unreviewed buildfix after r85440.
    22085 
    22086         * DumpRenderTree/win/UIDelegate.cpp:
    22087         (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
    22088 
    22089 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
    22090 
    22091         [WIN] Unreviewed buildfix after r85434.
    22092 
    22093         * DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
    22094         * DumpRenderTree/win/UIDelegate.cpp: Ditto.
    22095 
    22096 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
    22097 
    22098         [WIN] Unreviewed buildfix after r85434.
    22099 
    22100         * DumpRenderTree/win/FrameLoadDelegate.cpp:
    22101         (FrameLoadDelegate::FrameLoadDelegate):
    22102         * DumpRenderTree/win/UIDelegate.cpp:
    22103         (DRTUndoManager::DRTUndoManager):
    22104         (UIDelegate::UIDelegate):
    22105         (UIDelegate::resetUndoManager):
    22106 
    22107 2011-05-01  Eric Seidel  <eric@webkit.org>
    22108 
    22109         Reviewed by Adam Barth.
    22110 
    22111         Move scm.py into its own module in preparation for splitting it up
    22112         https://bugs.webkit.org/show_bug.cgi?id=59884
    22113 
    22114         * Scripts/webkitpy/common/checkout/scm/__init__.py: Added.
    22115         * Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
    22116         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
    22117         * Scripts/webkitpy/test/main.py:
    22118 
    22119 2011-05-01  Adam Barth  <abarth@webkit.org>
    22120 
    22121         Reviewed by Eric Seidel.
    22122 
    22123         webkit-patch fails when not run from root
    22124         https://bugs.webkit.org/show_bug.cgi?id=59882
    22125 
    22126         We need to set the CWD when running svn so that svn interprets file
    22127         paths relative to the root of the working copy.
    22128 
    22129         * Scripts/webkitpy/common/checkout/scm.py:
    22130 
    22131 2011-04-29  Eric Seidel  <eric@webkit.org>
    22132 
    22133         Reviewed by Adam Barth.
    22134 
    22135         land-safely patches should show show their place in the commit-queue
    22136         https://bugs.webkit.org/show_bug.cgi?id=59853
    22137 
    22138         This complicated the "should we show the bubbles or the submit-to-ews button"
    22139         logic substantially. :(  But now we'll show both the commit-queue position
    22140         as well as the submit-to-ews button for land-safely (cq+ only) patches.
    22141         Previously we would only show the submit-to-ews button.
    22142 
    22143         * QueueStatusServer/handlers/statusbubble.py:
    22144         * QueueStatusServer/templates/statusbubble.html:
    22145 
    22146 2011-04-29  Naoki Takano  <takano.naoki@gmail.com>
    22147 
    22148         Reviewed by Adam Barth.
    22149 
    22150         Add my name to contributers.
    22151         https://bugs.webkit.org/show_bug.cgi?id=59854
    22152 
    22153         * Scripts/webkitpy/common/config/committers.py:
    22154 
    22155 2011-04-29  Keith Kyzivat  <keith.kyzivat@nokia.com>
    22156 
    22157         Reviewed by Csaba Osztrogonác.
    22158 
    22159         [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0
    22160         https://bugs.webkit.org/show_bug.cgi?id=59772
    22161 
    22162         * Tools.pro:
    22163 
    22164 2011-04-29  Stephanie Lewis  <slewis@apple.com>
    22165 
    22166         Rubber-stamped by Adam Roben.   
    22167 
    22168         Remove the production configuration guard since installs only happen in production anyway. 
    22169         Works around a bug in Xcode
    22170 
    22171         * DumpRenderTree/mac/PerlSupport/Makefile:
    22172 
    22173 2011-04-29  Adam Roben  <aroben@apple.com>
    22174 
    22175         Remove a PHP setting that is now provided by httpd.conf
    22176 
    22177         r85155 added this setting, but putting it in httpd.conf makes more sense (since the setting
    22178         isn't dependent on paths that could be different on each user's machine).
    22179 
    22180         Reviewed by Sam Weinig.
    22181 
    22182         * Scripts/webkitperl/httpd.pm:
    22183         (getDefaultConfigForTestDirectory): Removed log_errors setting.
    22184 
    22185 2011-04-29  Jon Lee  <jonlee@apple.com>
    22186 
    22187         Unreviewed, Adding Jon Lee as a committer
    22188 
    22189         * Scripts/webkitpy/common/config/committers.py:
    22190 
    22191 2011-04-28  Ojan Vafai  <ojan@chromium.org>
    22192 
    22193         Reviewed by Tony Chang.
    22194 
    22195         fix pretty_patch_available and wdiff_available
    22196         https://bugs.webkit.org/show_bug.cgi?id=59761
    22197 
    22198         These methods rely on the check_* method being called first.
    22199         This would only happen when we actually tried to compute a diff,
    22200         but computing the diff happens on a different process.
    22201        
    22202         Also fix setting _wdiff_avialable to True by default.
    22203 
    22204         * Scripts/webkitpy/layout_tests/port/base.py:
    22205         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
    22206         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
    22207 
    22208 2011-04-29  Ojan Vafai  <ojan@chromium.org>
    22209 
    22210         Reviewed by Eric Seidel.
    22211 
    22212         exclude skipped tests from the summarized results
    22213         https://bugs.webkit.org/show_bug.cgi?id=59813
    22214 
    22215         If we find a need fo skipped tests later, we should either create
    22216         a skipped.json file or expose this some other way. As it is, the data
    22217         is unused and is hugely bloating the size of full_results.json.
    22218 
    22219         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
    22220 
    22221 2011-04-29  Adam Roben  <aroben@apple.com>
    22222 
    22223         Make DumpRenderTreeSupport get installed when the default configuration is built
    22224 
    22225         The default configuration is Production, but in that case the CONFIGURATION environment
    22226         variable is set to the empty string.
    22227 
    22228         Reviewed by Sam Weinig.
    22229 
    22230         * DumpRenderTree/mac/PerlSupport/Makefile: Set CONFIGURATION to Production if it isn't
    22231         already set so that later logic that depends on CONFIGURATION having that value will work.
    22232 
    22233 2011-04-29  Dean Jackson  <dino@apple.com>
    22234 
    22235         Reviewed by Simon Fraser.
    22236 
    22237         Add ENABLE macro for WebKitAnimation
    22238         https://bugs.webkit.org/show_bug.cgi?id=59729
    22239 
    22240         Add new feature to toggle WebKit Animation API.
    22241 
    22242         * Scripts/build-webkit:
    22243 
    22244 2011-04-29  Sam Weinig  <sam@webkit.org>
    22245 
    22246         Reviewed by Adam Roben.
    22247 
    22248         Make production the default build type for WebKitTestRunner, matching
    22249         all other projects.
    22250 
    2225121710        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
    2225221711
Note: See TracChangeset for help on using the changeset viewer.