Changeset 96682 in webkit

Timestamp:

Oct 5, 2011 1:21:59 AM (13 years ago)

Author:

yurys@chromium.org

Message:

[Chromium] Web Inspector: save inspector state into single string instead of string map
​https://bugs.webkit.org/show_bug.cgi?id=69335

Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.

Reviewed by Pavel Feldman.

• public/WebDevToolsAgent.h:
• public/WebDevToolsAgentClient.h:
• src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):

• src/WebDevToolsAgentImpl.h:

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebDevToolsAgent.h (modified) (1 diff)
• public/WebDevToolsAgentClient.h (modified) (1 diff)
• src/WebDevToolsAgentImpl.cpp (modified) (3 diffs)
• src/WebDevToolsAgentImpl.h (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-10-04  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: save inspector state into single string instead of string map
+        https://bugs.webkit.org/show_bug.cgi?id=69335
+
+        Now that Chromium side is updated, remove unused methods from the DevToolsAgent API.
+
+        Reviewed by Pavel Feldman.
+
+        * public/WebDevToolsAgent.h:
+        * public/WebDevToolsAgentClient.h:
+        * src/WebDevToolsAgentImpl.cpp:
+        (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
+        * src/WebDevToolsAgentImpl.h:
+
 2011-10-04  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebDevToolsAgent.h

@@ -66 +66 @@
 
     virtual void inspectElementAt(const WebPoint&) = 0;
-    // Deprecated. Will be removed shortly.
-    virtual void setRuntimeProperty(const WebString& name, const WebString& value) = 0;
     virtual void setProcessId(long) = 0;
 

trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h

@@ -47 +47 @@
     virtual int hostIdentifier() { return -1; }
 
-    // Notifies host upon runtime feature being enabled/disabled.
-    virtual void runtimePropertyChanged(const WebString& name, const WebString& value) { }
     // Save the agent state in order to pass it later into WebDevToolsAgent::reattach
     // if the same client is reattached to another agent.

trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp

@@ -72 +72 @@
 namespace WebKit {
 
-static const char kFrontendConnectedFeatureName[] = "frontend-connected";
-static const char kInspectorStateFeatureName[] = "inspector-state";
-
 class ClientMessageLoopAdapter : public PageScriptDebugServer::ClientMessageLoop {
 public:
@@ -251 +248 @@
 }
 
-void WebDevToolsAgentImpl::setRuntimeProperty(const WebString& name, const WebString& value)
-{
-    if (name == kInspectorStateFeatureName) {
-        InspectorController* ic = inspectorController();
-        ic->restoreInspectorStateFromCookie(value);
-    }
-}
-
 InspectorController* WebDevToolsAgentImpl::inspectorController()
 {
@@ -312 +301 @@
 void WebDevToolsAgentImpl::updateInspectorStateCookie(const String& state)
 {
-    m_client->runtimePropertyChanged(kInspectorStateFeatureName, state);
     m_client->saveAgentRuntimeState(state);
 }

trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h

@@ -82 +82 @@
     virtual void evaluateInWebInspector(long callId, const WebString& script);
     virtual void setJavaScriptProfilingEnabled(bool);
-    virtual void setRuntimeProperty(const WebString& name, const WebString& value);
     virtual void setProcessId(long);