Changeset 97224 in webkit

Timestamp:

Oct 11, 2011 8:45:47 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore: :checked pseudo selector not matching selected option
​https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <​mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

Test: fast/css/checked-pseudo-selector.html

Option element selected state need to be checked in checkOneSelector,
so that it can be considered as checked on querySelectorAll(':checked').

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests: :checked pseudo selector not matching selected option
​https://bugs.webkit.org/show_bug.cgi?id=63192

Patch by Sameer Patil <​mkrp87@motorola.com> on 2011-10-11
Reviewed by Kent Tamura.

• fast/css/checked-pseudo-selector-expected.txt: Added.
• fast/css/checked-pseudo-selector.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/checked-pseudo-selector-expected.txt (added)
• LayoutTests/fast/css/checked-pseudo-selector.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/SelectorChecker.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-10-11  Sameer Patil  <mkrp87@motorola.com>
+
+        :checked pseudo selector not matching selected option
+        https://bugs.webkit.org/show_bug.cgi?id=63192
+
+        Reviewed by Kent Tamura.
+
+        * fast/css/checked-pseudo-selector-expected.txt: Added.
+        * fast/css/checked-pseudo-selector.html: Added.
+
 2011-10-11  Ojan Vafai  <ojan@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-11  Sameer Patil  <mkrp87@motorola.com>
+
+        :checked pseudo selector not matching selected option 
+        https://bugs.webkit.org/show_bug.cgi?id=63192
+
+        Reviewed by Kent Tamura.
+
+        Test: fast/css/checked-pseudo-selector.html
+
+        Option element selected state need to be checked in checkOneSelector, 
+        so that it can be considered as checked on querySelectorAll(':checked').
+
+        * css/SelectorChecker.cpp:
+        (WebCore::SelectorChecker::checkOneSelector):
+
 2011-10-11  Ryuan Choi  <ryuan.choi@samsung.com>
 

trunk/Source/WebCore/css/SelectorChecker.cpp

@@ -41 +41 @@
 #include "InspectorInstrumentation.h"
 #include "NodeRenderStyle.h"
+#include "OptionElement.h"
 #include "Page.h"
 #include "PageGroup.h"
@@ -1117 +1118 @@
                 if (inputElement && inputElement->shouldAppearChecked() && !inputElement->isIndeterminate())
                     return true;
+
+                OptionElement* optionElement = toOptionElement(e);
+                if (optionElement && optionElement->selected())
+                    return true;
                 break;
             }