Changeset 97287 in webkit
- Timestamp:
- Oct 12, 2011 12:28:29 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r97282 r97287 1 2011-10-12 Anna Cavender <annacc@chromium.org> 2 3 Moving ScriptExecutionContext to the front of the argument list for 4 IDL constructors that use ConstructorWith=ScriptExecutionContext. 5 https://bugs.webkit.org/show_bug.cgi?id=69799 6 7 Reviewed by Adam Barth. 8 9 Tests: 10 - http/tests/eventsource/* (for EventSource) 11 - fast/filesystem/* (for Worker) 12 13 * bindings/js/JSEventSourceCustom.cpp: 14 (WebCore::JSEventSourceConstructor::constructJSEventSource): 15 * bindings/js/JSWorkerCustom.cpp: 16 (WebCore::JSWorkerConstructor::constructJSWorker): 17 * bindings/scripts/CodeGeneratorV8.pm: 18 (GenerateConstructorCallback): 19 * bindings/scripts/test/V8/V8TestInterface.cpp: 20 (WebCore::V8TestInterface::constructorCallback): 21 * page/EventSource.cpp: 22 (WebCore::EventSource::create): 23 * page/EventSource.h: 24 * workers/Worker.cpp: 25 (WebCore::Worker::create): 26 * workers/Worker.h: 27 1 28 2011-10-11 David Hyatt <hyatt@apple.com> 2 29 -
trunk/Source/WebCore/bindings/js/JSEventSourceCustom.cpp
r95901 r97287 57 57 58 58 ExceptionCode ec = 0; 59 RefPtr<EventSource> eventSource = EventSource::create( ustringToString(url), context, ec);59 RefPtr<EventSource> eventSource = EventSource::create(context, ustringToString(url), ec); 60 60 if (ec) { 61 61 setDOMException(exec, ec); -
trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp
r95362 r97287 66 66 67 67 ExceptionCode ec = 0; 68 RefPtr<Worker> worker = Worker::create( ustringToString(scriptURL), window->document(), ec);68 RefPtr<Worker> worker = Worker::create(window->document(), ustringToString(scriptURL), ec); 69 69 if (ec) { 70 70 setDOMException(exec, ec); -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r97280 r97287 1546 1546 push(@implContent, $parameterCheckString); 1547 1547 1548 my @contextArgument; 1548 1549 if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") { 1549 push(@ extraArgumentList, "context");1550 push(@contextArgument, "context"); 1550 1551 push(@implContent, <<END); 1551 1552 … … 1568 1569 } 1569 1570 1570 my $argumentString = join(", ", @ argumentList, @extraArgumentList);1571 my $argumentString = join(", ", @contextArgument, @argumentList, @extraArgumentList); 1571 1572 push(@implContent, "\n"); 1572 1573 push(@implContent, " RefPtr<${implClassName}> obj = ${implClassName}::create(${argumentString});\n"); -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
r96737 r97287 62 62 return throwError("TestInterface constructor's associated context is not available", V8Proxy::ReferenceError); 63 63 64 RefPtr<TestInterface> obj = TestInterface::create( str1, str2, context, ec);64 RefPtr<TestInterface> obj = TestInterface::create(context, str1, str2, ec); 65 65 if (ec) 66 66 goto fail; -
trunk/Source/WebCore/page/EventSource.cpp
r96621 r97287 70 70 } 71 71 72 PassRefPtr<EventSource> EventSource::create( const String& url, ScriptExecutionContext* context, ExceptionCode& ec)72 PassRefPtr<EventSource> EventSource::create(ScriptExecutionContext* context, const String& url, ExceptionCode& ec) 73 73 { 74 74 if (url.isEmpty()) { -
trunk/Source/WebCore/page/EventSource.h
r95901 r97287 52 52 WTF_MAKE_FAST_ALLOCATED; 53 53 public: 54 static PassRefPtr<EventSource> create( const String& url, ScriptExecutionContext*, ExceptionCode&);54 static PassRefPtr<EventSource> create(ScriptExecutionContext*, const String& url, ExceptionCode&); 55 55 virtual ~EventSource(); 56 56 -
trunk/Source/WebCore/workers/Worker.cpp
r92781 r97287 57 57 } 58 58 59 PassRefPtr<Worker> Worker::create( const String& url, ScriptExecutionContext* context, ExceptionCode& ec)59 PassRefPtr<Worker> Worker::create(ScriptExecutionContext* context, const String& url, ExceptionCode& ec) 60 60 { 61 61 RefPtr<Worker> worker = adoptRef(new Worker(context)); -
trunk/Source/WebCore/workers/Worker.h
r92781 r97287 52 52 class Worker : public AbstractWorker, private WorkerScriptLoaderClient { 53 53 public: 54 static PassRefPtr<Worker> create( const String& url, ScriptExecutionContext*, ExceptionCode&);54 static PassRefPtr<Worker> create(ScriptExecutionContext*, const String& url, ExceptionCode&); 55 55 virtual ~Worker(); 56 56
Note: See TracChangeset
for help on using the changeset viewer.