Changeset 97287 in webkit


Ignore:
Timestamp:
Oct 12, 2011 12:28:29 PM (12 years ago)
Author:
abarth@webkit.org
Message:

Moving ScriptExecutionContext to the front of the argument list for
IDL constructors that use ConstructorWith=ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=69799

Patch by Anna Cavender <annacc@chromium.org> on 2011-10-12
Reviewed by Adam Barth.

Tests:

  • http/tests/eventsource/* (for EventSource)
  • fast/filesystem/* (for Worker)
  • bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSourceConstructor::constructJSEventSource):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

  • page/EventSource.cpp:

(WebCore::EventSource::create):

  • page/EventSource.h:
  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/Worker.h:
Location:
trunk/Source/WebCore
Files:
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r97282 r97287  
     12011-10-12  Anna Cavender  <annacc@chromium.org>
     2
     3        Moving ScriptExecutionContext to the front of the argument list for
     4        IDL constructors that use ConstructorWith=ScriptExecutionContext.
     5        https://bugs.webkit.org/show_bug.cgi?id=69799
     6
     7        Reviewed by Adam Barth.
     8
     9        Tests:
     10        - http/tests/eventsource/* (for EventSource)
     11        - fast/filesystem/* (for Worker)
     12
     13        * bindings/js/JSEventSourceCustom.cpp:
     14        (WebCore::JSEventSourceConstructor::constructJSEventSource):
     15        * bindings/js/JSWorkerCustom.cpp:
     16        (WebCore::JSWorkerConstructor::constructJSWorker):
     17        * bindings/scripts/CodeGeneratorV8.pm:
     18        (GenerateConstructorCallback):
     19        * bindings/scripts/test/V8/V8TestInterface.cpp:
     20        (WebCore::V8TestInterface::constructorCallback):
     21        * page/EventSource.cpp:
     22        (WebCore::EventSource::create):
     23        * page/EventSource.h:
     24        * workers/Worker.cpp:
     25        (WebCore::Worker::create):
     26        * workers/Worker.h:
     27
    1282011-10-11  David Hyatt  <hyatt@apple.com>
    229
  • trunk/Source/WebCore/bindings/js/JSEventSourceCustom.cpp

    r95901 r97287  
    5757
    5858    ExceptionCode ec = 0;
    59     RefPtr<EventSource> eventSource = EventSource::create(ustringToString(url), context, ec);
     59    RefPtr<EventSource> eventSource = EventSource::create(context, ustringToString(url), ec);
    6060    if (ec) {
    6161        setDOMException(exec, ec);
  • trunk/Source/WebCore/bindings/js/JSWorkerCustom.cpp

    r95362 r97287  
    6666
    6767    ExceptionCode ec = 0;
    68     RefPtr<Worker> worker = Worker::create(ustringToString(scriptURL), window->document(), ec);
     68    RefPtr<Worker> worker = Worker::create(window->document(), ustringToString(scriptURL), ec);
    6969    if (ec) {
    7070        setDOMException(exec, ec);
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r97280 r97287  
    15461546    push(@implContent, $parameterCheckString);
    15471547
     1548    my @contextArgument;
    15481549    if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") {
    1549         push(@extraArgumentList, "context");
     1550        push(@contextArgument, "context");
    15501551        push(@implContent, <<END);
    15511552
     
    15681569    }
    15691570
    1570     my $argumentString = join(", ", @argumentList, @extraArgumentList);
     1571    my $argumentString = join(", ", @contextArgument, @argumentList, @extraArgumentList);
    15711572    push(@implContent, "\n");
    15721573    push(@implContent, "    RefPtr<${implClassName}> obj = ${implClassName}::create(${argumentString});\n");
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp

    r96737 r97287  
    6262        return throwError("TestInterface constructor's associated context is not available", V8Proxy::ReferenceError);
    6363
    64     RefPtr<TestInterface> obj = TestInterface::create(str1, str2, context, ec);
     64    RefPtr<TestInterface> obj = TestInterface::create(context, str1, str2, ec);
    6565    if (ec)
    6666        goto fail;
  • trunk/Source/WebCore/page/EventSource.cpp

    r96621 r97287  
    7070}
    7171
    72 PassRefPtr<EventSource> EventSource::create(const String& url, ScriptExecutionContext* context, ExceptionCode& ec)
     72PassRefPtr<EventSource> EventSource::create(ScriptExecutionContext* context, const String& url, ExceptionCode& ec)
    7373{
    7474    if (url.isEmpty()) {
  • trunk/Source/WebCore/page/EventSource.h

    r95901 r97287  
    5252        WTF_MAKE_FAST_ALLOCATED;
    5353    public:
    54         static PassRefPtr<EventSource> create(const String& url, ScriptExecutionContext*, ExceptionCode&);
     54        static PassRefPtr<EventSource> create(ScriptExecutionContext*, const String& url, ExceptionCode&);
    5555        virtual ~EventSource();
    5656
  • trunk/Source/WebCore/workers/Worker.cpp

    r92781 r97287  
    5757}
    5858
    59 PassRefPtr<Worker> Worker::create(const String& url, ScriptExecutionContext* context, ExceptionCode& ec)
     59PassRefPtr<Worker> Worker::create(ScriptExecutionContext* context, const String& url, ExceptionCode& ec)
    6060{
    6161    RefPtr<Worker> worker = adoptRef(new Worker(context));
  • trunk/Source/WebCore/workers/Worker.h

    r92781 r97287  
    5252    class Worker : public AbstractWorker, private WorkerScriptLoaderClient {
    5353    public:
    54         static PassRefPtr<Worker> create(const String& url, ScriptExecutionContext*, ExceptionCode&);
     54        static PassRefPtr<Worker> create(ScriptExecutionContext*, const String& url, ExceptionCode&);
    5555        virtual ~Worker();
    5656
Note: See TracChangeset for help on using the changeset viewer.