Changeset 97326 in webkit

Timestamp:

Oct 12, 2011 5:50:54 PM (13 years ago)

Author:

haraken@chromium.org

Message:

Implement a WebKitTransitionEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=69911

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/webkit-transition-event-constructor.html

• bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
• dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.

• platform/chromium/test_expectations.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (modified) (3 diffs)
• Source/WebCore/dom/WebKitTransitionEvent.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-10-12  Kentaro Hara  <haraken@chromium.org>
+
+        Implement a WebKitTransitionEvent constructor for V8
+        https://bugs.webkit.org/show_bug.cgi?id=69911
+
+        Reviewed by Adam Barth.
+
+        Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.
+
+        * platform/chromium/test_expectations.txt:
+
 2011-10-12  Ojan Vafai  <ojan@chromium.org>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -83 +83 @@
 // Tests for WebVTT parser for <track>.  Feature is not yet functional.
 BUGWK43668 SKIP : media/track/ = TIMEOUT
-
-// This will soon be fixed after implementing a WebKitTransitionEvent constructor for V8.
-BUGWK69829 : fast/events/constructors/webkit-transition-event-constructor.html = FAIL
 
 // Tests for MediaSource API. Feature is not yet functional.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-12  Kentaro Hara  <haraken@chromium.org>
+
+        Implement a WebKitTransitionEvent constructor for V8
+        https://bugs.webkit.org/show_bug.cgi?id=69911
+
+        Reviewed by Adam Barth.
+
+        Test: fast/events/constructors/webkit-transition-event-constructor.html
+
+        * bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
+        * dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
 2011-10-12  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

@@ -43 +43 @@
 #include "ProgressEvent.h"
 #include "WebKitAnimationEvent.h"
+#include "WebKitTransitionEvent.h"
 
 #include "OptionsObject.h"
@@ -59 +60 @@
 #include "V8Proxy.h"
 #include "V8WebKitAnimationEvent.h"
+#include "V8WebKitTransitionEvent.h"
 
 #include <wtf/RefPtr.h>
@@ -121 +123 @@
 INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
 INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
 
 

trunk/Source/WebCore/dom/WebKitTransitionEvent.idl

@@ -28 +28 @@
     interface [
         CanBeConstructed,
-        JSCustomConstructor
+        CustomConstructor
     ] WebKitTransitionEvent : Event {
     readonly attribute DOMString          propertyName;