Changeset 97741 in webkit

Timestamp:

Oct 18, 2011 5:39:11 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Option.value should trim extra internal html spaces
​https://bugs.webkit.org/show_bug.cgi?id=69455

Patch by Sachin Puranik <​jcqt43@motorola.com> on 2011-10-18
Reviewed by Kent Tamura.

Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.

Source/WebCore:

Test: fast/forms/option-value-trim-html-spaces.html

• dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.

LayoutTests:

• fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
• fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/option-value-trim-html-spaces-expected.txt (added)
• LayoutTests/fast/forms/option-value-trim-html-spaces.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/OptionElement.cpp (modified) (1 diff)
• Source/WebCore/html/HTMLOptionElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-10-18  Sachin Puranik  <jcqt43@motorola.com>
+
+        Option.value should trim extra internal html spaces
+        https://bugs.webkit.org/show_bug.cgi?id=69455
+
+        Reviewed by Kent Tamura.
+
+        Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.
+
+        * fast/forms/option-value-trim-html-spaces-expected.txt: Test case to test the text triming on the value attribute.
+        * fast/forms/option-value-trim-html-spaces.html: Test case to test the text triming on the value attribute.
+
 2011-10-18  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-18  Sachin Puranik  <jcqt43@motorola.com>
+
+        Option.value should trim extra internal html spaces
+        https://bugs.webkit.org/show_bug.cgi?id=69455
+
+        Reviewed by Kent Tamura.
+
+        Currently option.value does not trim the internal white space as suggested by spec. This patch implements the same.
+
+        Test: fast/forms/option-value-trim-html-spaces.html
+
+        * dom/OptionElement.cpp: Removed a function as this implementation is moved to the HTMLOptionElement.cpp file.
+        * html/HTMLOptionElement.cpp:
+        (WebCore::HTMLOptionElement::value): Implementation of .value function which will now trim the html white spaces.
+
 2011-10-18  Mihnea Ovidenie  <mihnea@adobe.com>
 

trunk/Source/WebCore/dom/OptionElement.cpp

@@ -118 +118 @@
 }
 
-String OptionElement::collectOptionValue(const OptionElementData& data, const Element* element)
-{
-    String value = data.value();
-    if (!value.isNull())
-        return value;
-
-    // Use the text if the value wasn't set.
-    return collectOptionInnerText(element).stripWhiteSpace();
-}
-
 // OptionElementData
 OptionElementData::OptionElementData()

trunk/Source/WebCore/html/HTMLOptionElement.cpp

@@ -156 +156 @@
 String HTMLOptionElement::value() const
 {
-    return OptionElement::collectOptionValue(m_data, this);
+    if (!m_data.value().isNull())
+        return m_data.value();
+
+    return collectOptionInnerText(this).stripWhiteSpace(isHTMLSpace).simplifyWhiteSpace(isHTMLSpace);
+
 }