Changeset 97805 in webkit

Timestamp:

Oct 18, 2011 4:06:48 PM (13 years ago)

Author:

adamk@chromium.org

Message:

[MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
​https://bugs.webkit.org/show_bug.cgi?id=68957

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/mutation/observe-characterdata.html

• dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

• fast/mutation/observe-characterdata-expected.txt: Added.
• fast/mutation/observe-characterdata.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/mutation/observe-characterdata-expected.txt (added)
• LayoutTests/fast/mutation/observe-characterdata.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/CharacterData.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-10-18  Adam Klein  <adamk@chromium.org>
+
+        [MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
+        https://bugs.webkit.org/show_bug.cgi?id=68957
+
+        Reviewed by Ryosuke Niwa.
+
+        * fast/mutation/observe-characterdata-expected.txt: Added.
+        * fast/mutation/observe-characterdata.html: Added.
+
 2011-10-18  Dirk Pranke  <dpranke@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-18  Adam Klein  <adamk@chromium.org>
+
+        [MutationObservers] Implement WebKitMutationObserver.observe for characterData changes
+        https://bugs.webkit.org/show_bug.cgi?id=68957
+
+        Reviewed by Ryosuke Niwa.
+
+        Test: fast/mutation/observe-characterdata.html
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::dispatchModifiedEvent):
+
 2011-10-18  Scott Byer  <scottbyer@chromium.org>
 

trunk/Source/WebCore/dom/CharacterData.cpp

@@ -28 +28 @@
 #include "InspectorInstrumentation.h"
 #include "MutationEvent.h"
+#include "MutationRecord.h"
 #include "NodeRenderingContext.h"
 #include "RenderText.h"
 #include "TextBreakIterator.h"
+#include "WebKitMutationObserver.h"
 
 using namespace std;
@@ -191 +193 @@
 void CharacterData::dispatchModifiedEvent(StringImpl* oldData)
 {
+#if ENABLE(MUTATION_OBSERVERS)
+    Vector<WebKitMutationObserver*> observers;
+    registeredMutationObserversOfType(observers, WebKitMutationObserver::CharacterData);
+    if (!observers.isEmpty()) {
+        RefPtr<MutationRecord> mutation = MutationRecord::createCharacterData(this);
+        for (size_t i = 0; i < observers.size(); ++i)
+            observers[i]->enqueueMutationRecord(mutation);
+    }
+#endif
     if (parentNode())
         parentNode()->childrenChanged();