Changeset 98200 in webkit


Ignore:
Timestamp:
Oct 23, 2011 12:27:47 AM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[GTK] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=69410

Tools:

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-10-23
Reviewed by Martin Robinson.

Implement the KeyDown function on Gtk platform.

  • WebKitTestRunner/GNUmakefile.am:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::dispatchEvent):
(WTR::getModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests.

Patch by Kaustubh Atrawalkar <Kaustubh Atrawalkar> on 2011-10-23
Reviewed by Martin Robinson.

  • platform/gtk-wk2/Skipped:
Location:
trunk
Files:
1 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r98199 r98200  
     12011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        [GTK] Implement KeyDown function for WebKit2 EventSender.
     4        https://bugs.webkit.org/show_bug.cgi?id=69410
     5
     6        Unskip passed tests.
     7
     8        Reviewed by Martin Robinson.
     9
     10        * platform/gtk-wk2/Skipped:
     11
    1122011-10-21  Geoffrey Garen  <ggaren@apple.com>
    213
  • trunk/LayoutTests/platform/gtk-wk2/Skipped

    r97494 r98200  
    8888plugins/fullscreen-plugins-dont-reload.html
    8989plugins/keyboard-events.html
    90 fast/dom/HTMLSelectElement/click-size-zero-no-crash.html
    9190fast/dom/access-key-iframe.html
    9291fast/dom/hidden-iframe-no-focus.html
    93 fast/dom/horizontal-scrollbar-in-rtl.html
    9492fast/dom/vertical-scrollbar-in-rtl.html
    95 fast/events/keypress-removed-node.html
    96 fast/events/attempt-select-all-with-wrong-modifier.html
    97 fast/events/keyevent-iframe-removed-crash.html
    9893fast/events/key-events-in-input-text.html
    9994fast/events/imagemap-norender-crash.html
    10095fast/events/special-key-events-in-input-text.html
    101 fast/events/select-element.html
    10296fast/events/access-key-self-destruct.html
    10397fast/events/multiline-link-arrow-navigation.html
     
    108102fast/events/selectstart-by-arrow-keys.html
    109103fast/events/tab-is-focusable-assert.html
    110 fast/events/keydown-keypress-preventDefault.html
    111 fast/events/keydown-1.html
    112104fast/events/focusingUnloadedFrame.html
    113105fast/events/onsearch-enter.html
    114106fast/events/inputText-never-fired-on-keydown-cancel.html
    115107fast/events/keydown-numpad-keys.html
    116 fast/events/select-onchange-crash.html
    117108fast/events/selectstart-by-arrow-keys-prevent-default.html
    118109fast/events/onchange-textfield.html
     
    121112fast/events/tabindex-focus-chain.html
    122113fast/events/node-event-anchor-lock.html
    123 fast/events/arrow-navigation.html
    124114fast/events/keydown-keypress-focus-change.html
    125115fast/events/js-keyboard-event-creation.html
     
    132122fast/events/onchange-searchfield.html
    133123fast/events/onchange-text-form-field.html
    134 fast/events/keydown-remove-frame.html
    135124fast/events/keypress-focus-change.html
    136 fast/events/keydown-function-keys.html
    137 fast/events/space-scroll-event.html
    138 fast/events/arrow-keys-on-body.html
    139 fast/events/recorded-keydown-event.html
    140125fast/events/popup-when-select-change.html
    141126fast/events/tab-imagemap.html
    142 fast/events/menu-keydown-on-hidden-element.html
    143 fast/events/anchor-empty-focus.html
    144127fast/events/key-events-in-input-button.html
    145128fast/repaint/fixed-move-after-keyboard-scroll.html
     
    201184editing/deleting/delete-ligature-002.html
    202185editing/deleting/skip-virama-001.html
    203 editing/deleting/forward-delete-key.html
    204186editing/deleting/delete-by-word-002.html
    205 editing/deleting/5729680.html
    206187editing/inserting/typing-tab-designmode-forms.html
    207188editing/inserting/typing-tab-designmode.html
     
    216197editing/input/option-page-up-down.html
    217198editing/input/style-change-during-input.html
    218 editing/input/page-up-down-scrolls.html
    219199
    220200# [GTK] Implement drag and drop support in WebKit2
     
    392372fast/events/resources/drag-outside-window-frame.html
    393373fast/events/mouseover-mouseout2.html
    394 fast/events/node-event-anchor-lock.html
    395374fast/events/mouseover-button.html
    396375fast/events/click-focus-anchor.html
     
    616595editing/selection/fake-drag.html
    617596editing/selection/paragraph-granularity.html
    618 editing/selection/5131716-3.html
    619597editing/selection/after-line-break.html
    620598editing/selection/anchor-focus3.html
    621 editing/selection/5057506-2.html
    622599editing/selection/anchor-focus1.html
    623600editing/selection/expanding-selections.html
  • trunk/Tools/ChangeLog

    r98195 r98200  
     12011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
     2
     3        [GTK] Implement KeyDown function for WebKit2 EventSender.
     4        https://bugs.webkit.org/show_bug.cgi?id=69410
     5
     6        Reviewed by Martin Robinson.
     7
     8        Implement the KeyDown function on Gtk platform.
     9
     10        * WebKitTestRunner/GNUmakefile.am:
     11        * WebKitTestRunner/TestController.cpp:
     12        (WTR::TestController::TestController):
     13        (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
     14        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
     15        (WTR::EventSenderProxy::EventSenderProxy):
     16        (WTR::dispatchEvent):
     17        (WTR::getModifiers):
     18        (WTR::getGDKKeySymForKeyRef):
     19        (WTR::EventSenderProxy::keyDown):
     20
    1212011-10-22  Zan Dobersek  <zandobersek@gmail.com>
    222
  • trunk/Tools/WebKitTestRunner/GNUmakefile.am

    r96740 r98200  
    1111Programs_WebKitTestRunner_SOURCES = \
    1212        Tools/WebKitTestRunner/gtk/main.cpp \
     13        Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp \
    1314        Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp \
    1415        Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp \
     
    2324        Tools/WebKitTestRunner/TestController.h \
    2425        Tools/WebKitTestRunner/TestInvocation.cpp \
    25         Tools/WebKitTestRunner/TestInvocation.h
     26        Tools/WebKitTestRunner/TestInvocation.h \
     27        Source/WebCore/platform/gtk/GtkVersioning.c
    2628
    2729Programs_WebKitTestRunner_CPPFLAGS = \
    2830        -include Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h \
    2931        -I$(srcdir)/Tools/WebKitTestRunner \
     32        -I$(srcdir)/Source/WebCore/platform/gtk \
    3033        -I$(top_builddir)/DerivedSources/WebKit2/include \
    3134        -DWEBKIT_EXEC_PATH=\"${shell pwd}/$(top_builddir)/Programs/\" \
  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r97407 r98200  
    3939#include <wtf/PassOwnPtr.h>
    4040
    41 #if PLATFORM(MAC) || PLATFORM(QT)
     41#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK)
    4242#include "EventSenderProxy.h"
    4343#endif
     
    7575    , m_shouldExitWhenWebProcessCrashes(true)
    7676    , m_beforeUnloadReturnValue(true)
    77 #if PLATFORM(MAC) || PLATFORM(QT)
     77#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK)
    7878    , m_eventSenderProxy(new EventSenderProxy(this))
    7979#endif
     
    541541WKRetainPtr<WKTypeRef> TestController::didReceiveSynchronousMessageFromInjectedBundle(WKStringRef messageName, WKTypeRef messageBody)
    542542{
    543 #if PLATFORM(MAC) || PLATFORM(QT)
     543#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK)
    544544    if (WKStringIsEqualToUTF8CString(messageName, "EventSender")) {
    545545        ASSERT(WKGetTypeID(messageBody) == WKDictionaryGetTypeID());
     
    566566        }
    567567
     568#if PLATFORM(MAC) || PLATFORM(QT)
    568569        if (WKStringIsEqualToUTF8CString(subMessageName, "MouseDown") || WKStringIsEqualToUTF8CString(subMessageName, "MouseUp")) {
    569570            WKRetainPtr<WKStringRef> buttonKey = adoptWK(WKStringCreateWithUTF8CString("Button"));
     
    618619            return 0;
    619620        }
    620 
     621#endif
    621622        ASSERT_NOT_REACHED();
    622623    }
Note: See TracChangeset for help on using the changeset viewer.