Changeset 98432 in webkit


Ignore:
Timestamp:
Oct 25, 2011 11:20:40 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

Flaky Test: editing/pasteboard/copy-standalone-image.html
​https://bugs.webkit.org/show_bug.cgi?id=61813

Reviewed by Adam Barth.

The flakiness was caused by the fact test didn't wait until iframe finish loading.

HTML5 section 4.8.2. the iframe element (​http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):

When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
of the iframe's browsing context's active document, the iframe must delay the load event of its document.

Since an image doesn't require an active parser, it does not delay the load event of the document.

  • editing/pasteboard/copy-standalone-image.html:
  • platform/chromium/test_expectations.txt:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r98430 r98432  
     12011-10-25  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Flaky Test: editing/pasteboard/copy-standalone-image.html
     4        https://bugs.webkit.org/show_bug.cgi?id=61813
     5
     6        Reviewed by Adam Barth.
     7
     8        The flakiness was caused by the fact test didn't wait until iframe finish loading.
     9
     10        HTML5 section 4.8.2. the iframe element (http://www.whatwg.org/specs/web-apps/current-work/#the-iframe-element):
     11            When there is an active parser in the iframe, and when anything in the iframe is delaying the load event
     12            of the iframe's browsing context's active document, the iframe must delay the load event of its document.
     13
     14        Since an image doesn't require an active parser, it does not delay the load event of the document.
     15
     16        * editing/pasteboard/copy-standalone-image.html:
     17        * platform/chromium/test_expectations.txt:
     18
    1192011-10-25  Xiaomei Ji  <xji@chromium.org>
    220

  • trunk/LayoutTests/editing/pasteboard/copy-standalone-image.html

    r80456 r98432  
    2626</style>
    2727</head>
    28 <body onload="editingTest()">
     28<body>
    2929
    3030<p>This is an automatic test of copying an image document.</p>
    … …  
    3333test is passed.</p>
    3434
    35 <iframe name="imageframe" src="../resources/abe.png">
     35<iframe name="imageframe" src="../resources/abe.png" onload="editingTest()">
    3636</iframe>
    3737

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r98420 r98432  
    669669// Flaky
    670670BUGCR31803 LINUX MAC : editing/inserting/12882.html = PASS IMAGE
    671 BUGCR31803 MAC WIN : editing/pasteboard/copy-standalone-image.html = PASS TEXT IMAGE IMAGE+TEXT
    672671
    673672// Tests added in r69269.
Note: See TracChangeset for help on using the changeset viewer.